Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2904193002: [Telemetry] Reduce a websocket connection between telemetry & devtool browser target (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 6 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Reduce a websocket connection between telemetry & devtool browser target Before this, SystemInfoBackend creates it own socket connection with devtool browser targe. With this fix, it reuses the browser_inspector_websocket in DevToolsClientBackend (consistent with tracing_backend & memory_backend) Review-Url: https://codereview.chromium.org/2904193002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/02e58de92d78a5d8455a5973ef43b6e7c3cca48b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 3 chunks +2 lines, -7 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py View 3 chunks +1 line, -6 lines 0 comments Download
D telemetry/telemetry/internal/backends/chrome/system_info_backend.py View 1 chunk +0 lines, -31 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py View 5 chunks +15 lines, -0 lines 0 comments Download
A telemetry/telemetry/internal/backends/chrome_inspector/system_info_backend.py View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
nednguyen
3 years, 7 months ago (2017-05-26 14:12:37 UTC) #3
perezju
lgtm
3 years, 7 months ago (2017-05-26 14:45:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904193002/1
3 years, 7 months ago (2017-05-26 16:01:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/02e58de92d78a5d8455a5973ef43b6e7c3cca48b
3 years, 7 months ago (2017-05-26 16:03:40 UTC) #13
Ken Russell (switch to Gerrit)
Thanks after the fact for this cleanup and simplification. I didn't understand when writing this ...
3 years, 6 months ago (2017-05-31 03:18:53 UTC) #14
charliea (OOO until 10-5)
3 years, 6 months ago (2017-05-31 16:26:26 UTC) #15
Message was sent while issue was closed.
lgtm

nice cleanup :-)

Powered by Google App Engine
This is Rietveld 408576698