telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py - Issue 2904193002: [Telemetry] Reduce a websocket connection between telemetry & devtool browser target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

Issue 2904193002: [Telemetry] Reduce a websocket connection between telemetry & devtool browser target (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py ('k') | telemetry/telemetry/internal/backends/chrome/system_info_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

diff --git a/telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

index fac37cb2e7fab7568f9a413f0ce583feef1fa333..d62b26a0067f63f4d97325e23fb06fb4d1157d55 100644

--- a/telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

+++ b/telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

@@ -9,7 +9,6 @@ import re

import urllib2

from telemetry.internal.backends.chrome import chrome_browser_backend

-from telemetry.internal.backends.chrome import system_info_backend

import py_utils

@@ -29,7 +28,6 @@ class IosBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

self._webviews = []

self._port = None

self._page = None

- self._system_info_backend = None

self.UpdateRunningBrowsersInfo()

def UpdateRunningBrowsersInfo(self):

@@ -103,10 +101,7 @@ class IosBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

return debug_urls

def GetSystemInfo(self):

- if self._system_info_backend is None:

- self._system_info_backend = system_info_backend.SystemInfoBackend(

- self._port, self._page)

- return self._system_info_backend.GetSystemInfo()

+ return None

def IsBrowserRunning(self):

return bool(self._webviews)