Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: telemetry/telemetry/internal/backends/chrome/system_info_backend.py

Issue 2904193002: [Telemetry] Reduce a websocket connection between telemetry & devtool browser target (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/chrome/system_info_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome/system_info_backend.py b/telemetry/telemetry/internal/backends/chrome/system_info_backend.py
deleted file mode 100644
index 4f716338db02cff74e7aa3f11222277a45914b6b..0000000000000000000000000000000000000000
--- a/telemetry/telemetry/internal/backends/chrome/system_info_backend.py
+++ /dev/null
@@ -1,31 +0,0 @@
-# Copyright 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from telemetry.internal.backends.chrome_inspector import inspector_websocket
-from telemetry.internal.platform import system_info
-from telemetry.internal.util import camel_case
-
-
-class SystemInfoBackend(object):
- def __init__(self, devtools_port, devtools_page=None):
- self._port = devtools_port
- self._page = devtools_page
-
- def GetSystemInfo(self, timeout=10):
- req = {'method': 'SystemInfo.getInfo'}
- websocket = inspector_websocket.InspectorWebsocket()
- try:
- if self._page:
- websocket.Connect('ws://127.0.0.1:%i/devtools/page/%i' %
- (self._port, self._page), timeout)
- else:
- websocket.Connect('ws://127.0.0.1:%i/devtools/browser' % self._port,
- timeout)
- res = websocket.SyncRequest(req, timeout)
- finally:
- websocket.Disconnect()
- if 'error' in res:
- return None
- return system_info.SystemInfo.FromDict(
- camel_case.ToUnderscore(res['result']))

Powered by Google App Engine
This is Rietveld 408576698