[Payments] Use C++ metric enums in Java.

[Payments] Use C++ metric enums in Java.

BUG=726771
Review-Url: https://codereview.chromium.org/2904083003
Cr-Commit-Position: refs/heads/master@{#476034}
Committed: https://chromium.googlesource.com/chromium/src/+/77b98c4aea6f046286c70ea05a083002ac7db519

[sebsg, 2017-05-26 19:24:16]

sebsg@chromium.org changed reviewers:
+ gogerald@chromium.org, mathp@chromium.org

[sebsg, 2017-05-26 19:24:16]

mathp and gogeral, could you please take a look? Thanks!

[gogerald1, 2017-05-29 16:05:42]

lgtm with minor comments

https://codereview.chromium.org/2904083003/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2904083003/diff/1/chrome/BUILD.gn#newcode1614
chrome/BUILD.gn:1614: java_cpp_enum("journey_logger_enum_javagen") {
*payments_journey_logger_enum_javagen*?

https://codereview.chromium.org/2904083003/diff/1/components/payments/core/jo...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2904083003/diff/1/components/payments/core/jo...
components/payments/core/journey_logger.h:47: // A Java counterpart will be
generated for this enum.
no need this line since you comment and the beginning?

[sebsg, 2017-05-29 16:40:29]

Patchset #2 (id:20001) has been deleted

[sebsg, 2017-05-29 16:41:45]

Patchset #2 (id:40001) has been deleted

[sebsg, 2017-05-29 16:44:49]

Thanks, gogerald.

Math could you please take a look?

https://codereview.chromium.org/2904083003/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2904083003/diff/1/chrome/BUILD.gn#newcode1614
chrome/BUILD.gn:1614: java_cpp_enum("journey_logger_enum_javagen") {
On 2017/05/29 16:05:42, gogerald1 wrote:
> *payments_journey_logger_enum_javagen*?

Done.

https://codereview.chromium.org/2904083003/diff/1/components/payments/core/jo...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2904083003/diff/1/components/payments/core/jo...
components/payments/core/journey_logger.h:47: // A Java counterpart will be
generated for this enum.
On 2017/05/29 16:05:42, gogerald1 wrote:
> no need this line since you comment and the beginning?

Oops this one slipped past me, thanks!

[Mathieu, 2017-05-29 16:48:46]

lgtm

https://codereview.chromium.org/2904083003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
(right):

https://codereview.chromium.org/2904083003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java:12:
public final class PaymentRequestMetrics {
should everything in here move to native, too (in an upcoming cl)?

[sebsg, 2017-05-29 16:55:57]

Thanks, sending to CQ

https://codereview.chromium.org/2904083003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
(right):

https://codereview.chromium.org/2904083003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java:12:
public final class PaymentRequestMetrics {
On 2017/05/29 16:48:46, Mathieu wrote:
> should everything in here move to native, too (in an upcoming cl)?

Yep! Working on it.

[sebsg, 2017-05-29 16:56:04]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-05-29 16:56:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2904083003/#ps80001
(title: "Addressed gogerald's coments")

[commit-bot: I haz the power, 2017-05-29 16:56:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 17:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 17:03:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sebsg, 2017-05-29 17:22:08]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 17:22:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 17:37:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 17:37:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sebsg, 2017-05-29 18:58:04]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 18:58:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-05-29 19:20:38]

Patchset #4 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-05-29 19:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 19:46:44]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[sebsg, 2017-05-29 20:17:57]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 20:18:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 21:49:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 21:49:05]

Dry run: This issue passed the CQ dry run.

[sebsg, 2017-05-29 21:59:30]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-05-29 21:59:31]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2904083003/#ps140001
(title: "Enum rename for Windows")

[commit-bot: I haz the power, 2017-05-29 21:59:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 22:08:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 22:08:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sebsg, 2017-05-29 23:37:03]

sebsg@chromium.org changed reviewers:
+ dtrainor@chromium.org

[sebsg, 2017-05-29 23:37:04]

Hi dtrainor@chromium.org could you please review chrome/android/BUILD.gn?

Thanks!

[sebsg, 2017-05-29 23:37:57]

sebsg@chromium.org changed reviewers:
+ thestig@chromium.org

[sebsg, 2017-05-29 23:37:59]

Hi, thestig@ could you please review chrome/BUILD.gn?

Thanks!

[Lei Zhang, 2017-05-30 19:00:30]

lgtm

[David Trainor- moved to gerrit, 2017-05-31 15:52:00]

chrome/android/BUILD.gn lgtm!

[sebsg, 2017-05-31 18:13:14]

The CQ bit was checked by sebsg@chromium.org

[commit-bot: I haz the power, 2017-05-31 18:14:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 19:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 19:49:56]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sebsg, 2017-05-31 19:54:57]

The CQ bit was checked by sebsg@chromium.org

[commit-bot: I haz the power, 2017-05-31 19:56:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:34:35]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1496260497444120,
"parent_rev": "6a32dcf0c4968f022b2f603912ce2804606636e1", "commit_rev":
"77b98c4aea6f046286c70ea05a083002ac7db519"}

[commit-bot: I haz the power, 2017-05-31 21:34:45]

Description was changed from

==========
[Payments] Use C++ metric enums in Java.

BUG=726771
==========

to

==========
[Payments] Use C++ metric enums in Java.

BUG=726771

Review-Url: https://codereview.chromium.org/2904083003
Cr-Commit-Position: refs/heads/master@{#476034}
Committed:
https://chromium.googlesource.com/chromium/src/+/77b98c4aea6f046286c70ea05a08...
==========

[commit-bot: I haz the power, 2017-05-31 21:34:46]

Committed patchset #5 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/77b98c4aea6f046286c70ea05a08...