Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5584)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc

Issue 2904083003: [Payments] Use C++ metric enums in Java. (Closed)
Patch Set: Enum rename for Windows Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java ('k') | components/payments/core/journey_logger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc
diff --git a/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc b/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc
index b9c76b8bb61106fd70b268ee3148b371ed0422d2..eb21148744300fa5c786462a78b4c20df1854fa4 100644
--- a/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc
+++ b/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc
@@ -63,8 +63,8 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
JourneyLogger::CAN_MAKE_PAYMENT_USED, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.EffectOnShow",
- JourneyLogger::CMP_SHOW_DID_SHOW |
- JourneyLogger::CMP_SHOW_COULD_MAKE_PAYMENT,
+ JourneyLogger::CMP_EFFECT_ON_SHOW_DID_SHOW |
+ JourneyLogger::CMP_EFFECT_ON_SHOW_COULD_MAKE_PAYMENT,
1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.TrueWithShowEffectOnCompletion",
@@ -100,8 +100,8 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
JourneyLogger::CAN_MAKE_PAYMENT_USED, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.EffectOnShow",
- JourneyLogger::CMP_SHOW_DID_SHOW |
- JourneyLogger::CMP_SHOW_COULD_MAKE_PAYMENT,
+ JourneyLogger::CMP_EFFECT_ON_SHOW_DID_SHOW |
+ JourneyLogger::CMP_EFFECT_ON_SHOW_COULD_MAKE_PAYMENT,
1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.TrueWithShowEffectOnCompletion",
@@ -131,8 +131,8 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
JourneyLogger::CAN_MAKE_PAYMENT_USED, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.EffectOnShow",
- JourneyLogger::CMP_SHOW_DID_SHOW |
- JourneyLogger::CMP_SHOW_COULD_MAKE_PAYMENT,
+ JourneyLogger::CMP_EFFECT_ON_SHOW_DID_SHOW |
+ JourneyLogger::CMP_EFFECT_ON_SHOW_COULD_MAKE_PAYMENT,
1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.TrueWithShowEffectOnCompletion",
@@ -176,7 +176,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
JourneyLogger::CAN_MAKE_PAYMENT_USED, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.EffectOnShow",
- JourneyLogger::CMP_SHOW_DID_SHOW, 1);
+ JourneyLogger::CMP_EFFECT_ON_SHOW_DID_SHOW, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.FalseWithShowEffectOnCompletion",
JourneyLogger::COMPLETION_STATUS_COMPLETED, 1);
@@ -208,7 +208,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
JourneyLogger::CAN_MAKE_PAYMENT_USED, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.EffectOnShow",
- JourneyLogger::CMP_SHOW_DID_SHOW, 1);
+ JourneyLogger::CMP_EFFECT_ON_SHOW_DID_SHOW, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.FalseWithShowEffectOnCompletion",
JourneyLogger::COMPLETION_STATUS_OTHER_ABORTED, 1);
@@ -234,7 +234,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
JourneyLogger::CAN_MAKE_PAYMENT_USED, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.EffectOnShow",
- JourneyLogger::CMP_SHOW_DID_SHOW, 1);
+ JourneyLogger::CMP_EFFECT_ON_SHOW_DID_SHOW, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.FalseWithShowEffectOnCompletion",
JourneyLogger::COMPLETION_STATUS_USER_ABORTED, 1);
@@ -261,7 +261,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
JourneyLogger::CAN_MAKE_PAYMENT_USED, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.EffectOnShow",
- JourneyLogger::CMP_SHOW_COULD_MAKE_PAYMENT, 1);
+ JourneyLogger::CMP_EFFECT_ON_SHOW_COULD_MAKE_PAYMENT, 1);
}
IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
@@ -282,7 +282,8 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
JourneyLogger::CAN_MAKE_PAYMENT_USED, 1);
histogram_tester.ExpectBucketCount(
"PaymentRequest.CanMakePayment.Used.EffectOnShow",
- JourneyLogger::CMP_SHOW_COULD_NOT_MAKE_PAYMENT_AND_DID_NOT_SHOW, 1);
+ JourneyLogger::CMP_EFFECT_ON_SHOW_COULD_NOT_MAKE_PAYMENT_AND_DID_NOT_SHOW,
+ 1);
}
IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentMetricsTest,
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java ('k') | components/payments/core/journey_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698