chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java - Issue 2904083003: [Payments] Use C++ metric enums in Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

Issue 2904083003: [Payments] Use C++ metric enums in Java. (Closed)

Patch Set: Enum rename for Windows Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

index 0e95190a80526de3112e14c73fe1f373a25ed7fe..30376cfea3e78589eff78e005f05a2ed6b0cd984 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java

@@ -90,18 +90,14 @@ public class PaymentRequestContactDetailsAndFreeShippingTest implements MainActi

mPaymentRequestTestRule.triggerUIAndWait(mPaymentRequestTestRule.getReadyToPay());

// Make sure that only the appropriate enum value was logged.

- for (int i = 0; i < PaymentRequestMetrics.REQUESTED_INFORMATION_MAX; ++i) {

- Assert.assertEquals(

- (i

- == (PaymentRequestMetrics.REQUESTED_INFORMATION_EMAIL

- | PaymentRequestMetrics

- .REQUESTED_INFORMATION_PHONE

- | PaymentRequestMetrics

- .REQUESTED_INFORMATION_SHIPPING

- | PaymentRequestMetrics

- .REQUESTED_INFORMATION_NAME)

- ? 1

- : 0),

+ for (int i = 0; i < RequestedInformation.MAX; ++i) {

+ Assert.assertEquals((i

+ == (RequestedInformation.EMAIL

+ | RequestedInformation.PHONE

+ | RequestedInformation.SHIPPING

+ | RequestedInformation.NAME)

+ ? 1

+ : 0),

RecordHistogram.getHistogramValueCountForTesting(

"PaymentRequest.RequestedInformation", i));

}