(reland) Check missing headers in the build on CQ

(reland) Check missing headers in the build on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774, 725877
Review-Url: https://codereview.chromium.org/2903733004
Cr-Commit-Position: refs/heads/master@{#474570}
Committed: https://chromium.googlesource.com/chromium/src/+/2f5a1ee159209aace78614d6012c361de5c3d2c3

[wychen, 2017-05-24 20:47:27]

wychen@chromium.org changed reviewers:
+ dpranke@chromium.org

[wychen, 2017-05-24 20:47:27]

PTAL. It should work on waterfall this time.

[Dirk Pranke, 2017-05-25 01:39:31]

https://codereview.chromium.org/2903733004/diff/40001/testing/buildbot/chromi...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/2903733004/diff/40001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:3523: "scripts": [
Why are you moving these from the "Linux Tests" builder? Is it because the Tests
builder doesn't have a full checkout?

I'm not sure that and test entries on a build-only bot will even be run, so that
might be something we need to change ...

[wychen, 2017-05-25 02:05:24]

https://codereview.chromium.org/2903733004/diff/40001/testing/buildbot/chromi...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/2903733004/diff/40001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:3523: "scripts": [
On 2017/05/25 01:39:31, Dirk Pranke (slow) wrote:
> Why are you moving these from the "Linux Tests" builder? Is it because the
Tests
> builder doesn't have a full checkout?

Exactly. The analysis relies on having a fully compiled OUT_DIR.

> I'm not sure that and test entries on a build-only bot will even be run, so
that
> might be something we need to change ...

It runs fine. See the trybot results in PS2 and PS3.

[Dirk Pranke, 2017-05-25 02:14:50]

On 2017/05/25 02:05:24, wychen wrote:
>
https://codereview.chromium.org/2903733004/diff/40001/testing/buildbot/chromi...
> File testing/buildbot/chromium.linux.json (right):
> 
>
https://codereview.chromium.org/2903733004/diff/40001/testing/buildbot/chromi...
> testing/buildbot/chromium.linux.json:3523: "scripts": [
> On 2017/05/25 01:39:31, Dirk Pranke (slow) wrote:
> > Why are you moving these from the "Linux Tests" builder? Is it because the
> Tests
> > builder doesn't have a full checkout?
> 
> Exactly. The analysis relies on having a fully compiled OUT_DIR.
> 
> > I'm not sure that and test entries on a build-only bot will even be run, so
> that
> > might be something we need to change ...
> 
> It runs fine. See the trybot results in PS2 and PS3.

Interesting. I wonder if it'll run on the waterfall bots as well.

Well, lgtm to try it out, then.

[wychen, 2017-05-25 02:19:20]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-05-25 02:20:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 05:45:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495678760445850,
"parent_rev": "061530882425512579d47b110cd07fc2fc8dc43c", "commit_rev":
"2f5a1ee159209aace78614d6012c361de5c3d2c3"}

[commit-bot: I haz the power, 2017-05-25 05:45:52]

Description was changed from

==========
(reland) Check missing headers in the build on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774, 725877
==========

to

==========
(reland) Check missing headers in the build on CQ

This script is run on the following bots on CQ:
- linux_chromium_dbg_ng
- linux_chromium_rel_ng

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774, 725877

Review-Url: https://codereview.chromium.org/2903733004
Cr-Commit-Position: refs/heads/master@{#474570}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f5a1ee159209aace78614d6012c...
==========

[commit-bot: I haz the power, 2017-05-25 05:45:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2f5a1ee159209aace78614d6012c...

[wychen, 2017-05-25 06:34:10]

Works on the waterfall as well.

https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg...
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/8...

[Dirk Pranke, 2017-05-25 16:08:03]

On 2017/05/25 06:34:10, wychen wrote:
> Works on the waterfall as well.
> 
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg...
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/8...

Great :).

[wychen, 2017-05-25 17:42:10]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2897173007/ by wychen@chromium.org.

The reason for reverting is: Hit assertion in bots. crbug.com/725877.