Check missing headers in the build on Android bots

Check missing headers in the build on Android bots

Add to the following bots on CQ:
- android_n5x_swarming_dbg
- android_arm64_dbg_recipe
- android_clang_dbg_recipe

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774

[wychen, 2017-06-03 07:21:26]

Description was changed from

==========
Check missing headers in the build on Android bots

Add to the following bots on CQ:
- android_n5x_swarming_dbg
- android_arm64_dbg_recipe
- android_clang_dbg_recipe

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774
==========

to

==========
Check missing headers in the build on Android bots

Add to the following bots on CQ:
- android_n5x_swarming_dbg
- android_arm64_dbg_recipe
- android_clang_dbg_recipe

Note that this script can only be added to bots that have "all"
in "additional_compile_targets".

BUG=661774
==========

[wychen, 2017-06-03 07:21:27]

wychen@chromium.org changed reviewers:
+ dpranke@chromium.org

[wychen, 2017-06-03 07:26:49]

This is still WIP, and we can think about landing it after making linux bots run
header checker reliably.

As far as I understand, this CL doesn't work because these bots are configured
with analyze_mode='compile', so that the steps after compilation are skipped.
Should we make analyze_mode='compile' mean skipping tests but not scripts?

[Dirk Pranke, 2017-06-07 02:04:33]

On 2017/06/03 07:26:49, wychen wrote:
> This is still WIP, and we can think about landing it after making linux bots
run
> header checker reliably.
> 
> As far as I understand, this CL doesn't work because these bots are configured
> with analyze_mode='compile', so that the steps after compilation are skipped.
> Should we make analyze_mode='compile' mean skipping tests but not scripts?

Good question. I'll have to think about that, but it might be okay.

[wychen, 2017-06-07 02:17:18]

On 2017/06/07 02:04:33, Dirk Pranke (slow) wrote:
> On 2017/06/03 07:26:49, wychen wrote:
> > This is still WIP, and we can think about landing it after making linux bots
> run
> > header checker reliably.
> > 
> > As far as I understand, this CL doesn't work because these bots are
configured
> > with analyze_mode='compile', so that the steps after compilation are
skipped.
> > Should we make analyze_mode='compile' mean skipping tests but not scripts?
> 
> Good question. I'll have to think about that, but it might be okay.

We could either allow scripts in compile-only bots, or add compile target "all"
to a normal bot. The former might be more cost-effective.
The downside could be that we run checkdeps and checkperms unnecessarily on some
bots.

[wychen, 2017-06-12 23:12:33]

On 2017/06/07 02:17:18, wychen wrote:
> On 2017/06/07 02:04:33, Dirk Pranke (slow) wrote:
> > On 2017/06/03 07:26:49, wychen wrote:
> > > This is still WIP, and we can think about landing it after making linux
bots
> > run
> > > header checker reliably.
> > > 
> > > As far as I understand, this CL doesn't work because these bots are
> configured
> > > with analyze_mode='compile', so that the steps after compilation are
> skipped.
> > > Should we make analyze_mode='compile' mean skipping tests but not scripts?
> > 
> > Good question. I'll have to think about that, but it might be okay.
> 
> We could either allow scripts in compile-only bots, or add compile target
"all"
> to a normal bot. The former might be more cost-effective.
> The downside could be that we run checkdeps and checkperms unnecessarily on
some
> bots.

Looks like we can modify this part:
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...

I don't really know how to test this code base though.

[Dirk Pranke, 2017-06-13 05:39:41]

On 2017/06/12 23:12:33, wychen wrote:
> Looks like we can modify this part:
>
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...

Yes, but there are downsides to doing so. The challenge is to figure out which
set of tradeoffs I'm least unhappy about :).

[Dirk Pranke, 2017-06-17 00:11:14]

On 2017/06/13 05:39:41, Dirk Pranke wrote:
> On 2017/06/12 23:12:33, wychen wrote:
> > Looks like we can modify this part:
> >
>
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...
> 
> Yes, but there are downsides to doing so. The challenge is to figure out which
> set of tradeoffs I'm least unhappy about :).

Let's table this for now, given the other discussions we've had about header
checking.

[wychen, 2017-06-17 00:13:39]

On 2017/06/17 00:11:14, Dirk Pranke wrote:
> On 2017/06/13 05:39:41, Dirk Pranke wrote:
> > On 2017/06/12 23:12:33, wychen wrote:
> > > Looks like we can modify this part:
> > >
> >
>
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_...
> > 
> > Yes, but there are downsides to doing so. The challenge is to figure out
which
> > set of tradeoffs I'm least unhappy about :).
> 
> Let's table this for now, given the other discussions we've had about header
> checking.

Yes. Let's do presubmit and FYI linux bots first, and then think about FYI bots
on other OSes.