Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: testing/scripts/check_gn_headers.py

Issue 2903733004: (reland) Check missing headers in the build on CQ (Closed)
Patch Set: update whitelist Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/scripts/check_gn_headers.py
diff --git a/testing/scripts/check_gn_headers.py b/testing/scripts/check_gn_headers.py
new file mode 100755
index 0000000000000000000000000000000000000000..7aa36a6a8c208ad7ddeaf2d711421340128e97e6
--- /dev/null
+++ b/testing/scripts/check_gn_headers.py
@@ -0,0 +1,46 @@
+#!/usr/bin/env python
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import json
+import os
+import sys
+
+
+import common
+
+
+def main_run(args):
+ with common.temporary_file() as tempfile_path:
+ rc = common.run_command([
+ sys.executable,
+ os.path.join(common.SRC_DIR, 'build', 'check_gn_headers.py'),
+ '--out-dir',
+ os.path.join(args.paths['checkout'], 'out', args.build_config_fs),
+ '--whitelist',
+ os.path.join(common.SRC_DIR, 'build', 'check_gn_headers_whitelist.txt'),
+ '--json', tempfile_path
+ ], cwd=common.SRC_DIR)
+
+ with open(tempfile_path) as f:
+ failures = json.load(f)
+
+ json.dump({
+ 'valid': True,
+ 'failures': failures,
+ }, args.output)
+
+ return rc
+
+
+def main_compile_targets(args):
+ json.dump([], args.output)
+
+
+if __name__ == '__main__':
+ funcs = {
+ 'run': main_run,
+ 'compile_targets': main_compile_targets,
+ }
+ sys.exit(common.run_script(sys.argv[1:], funcs))
« testing/buildbot/chromium.linux.json ('K') | « testing/buildbot/chromium.linux.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698