DevTools: shorten console links to 40 chars

third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 131 matching lines @@
   /**
    * @param {?SDK.Target} target
    * @param {?string} scriptId
    * @param {string} sourceURL
    * @param {number} lineNumber
    * @param {number=} columnNumber
    * @param {string=} classes
    * @return {?Element}
    */
   maybeLinkifyScriptLocation(target, scriptId, sourceURL, lineNumber, columnNumber, classes) {
-    var fallbackAnchor =
-        sourceURL ? Components.Linkifier.linkifyURL(sourceURL, undefined, classes, lineNumber, columnNumber) : null;
+    var fallbackAnchor = sourceURL ?
+        Components.Linkifier.linkifyURL(
+            sourceURL, undefined, classes, lineNumber, columnNumber, undefined, this._maxLength) :
+        null;
     if (!target || target.isDisposed())
       return fallbackAnchor;
     var debuggerModel = target.model(SDK.DebuggerModel);
     if (!debuggerModel)
       return fallbackAnchor;
 
     var rawLocation =
         (scriptId ? debuggerModel.createRawLocationByScriptId(scriptId, lineNumber, columnNumber || 0) : null) ||
         debuggerModel.createRawLocationByURL(sourceURL, lineNumber, columnNumber || 0);
     if (!rawLocation)
@@ skipping 16 matching lines @@
    * @param {?SDK.Target} target
    * @param {?string} scriptId
    * @param {string} sourceURL
    * @param {number} lineNumber
    * @param {number=} columnNumber
    * @param {string=} classes
    * @return {!Element}
    */
   linkifyScriptLocation(target, scriptId, sourceURL, lineNumber, columnNumber, classes) {
     return this.maybeLinkifyScriptLocation(target, scriptId, sourceURL, lineNumber, columnNumber, classes) ||
-        Components.Linkifier.linkifyURL(sourceURL, undefined, classes, lineNumber, columnNumber);
+        Components.Linkifier.linkifyURL(
+            sourceURL, undefined, classes, lineNumber, columnNumber, undefined, this._maxLength);
   }
 
   /**
    * @param {!SDK.DebuggerModel.Location} rawLocation
    * @param {string} fallbackUrl
    * @param {string=} classes
    * @return {!Element}
    */
   linkifyRawLocation(rawLocation, fallbackUrl, classes) {
     return this.linkifyScriptLocation(
@@ skipping 15 matching lines @@
   /**
    * @param {!SDK.Target} target
    * @param {!Protocol.Runtime.StackTrace} stackTrace
    * @param {string=} classes
    * @return {!Element}
    */
   linkifyStackTraceTopFrame(target, stackTrace, classes) {
     console.assert(stackTrace.callFrames && stackTrace.callFrames.length);
 
     var topFrame = stackTrace.callFrames[0];
-    var fallbackAnchor =
-        Components.Linkifier.linkifyURL(topFrame.url, undefined, classes, topFrame.lineNumber, topFrame.columnNumber);
+    var fallbackAnchor = Components.Linkifier.linkifyURL(
+        topFrame.url, undefined, classes, topFrame.lineNumber, topFrame.columnNumber, undefined, this._maxLength);
     if (target.isDisposed())
       return fallbackAnchor;
 
     var debuggerModel = target.model(SDK.DebuggerModel);
     var rawLocations = debuggerModel.createRawLocationsByStackTrace(stackTrace);
     if (rawLocations.length === 0)
       return fallbackAnchor;
 
     var anchor = Components.Linkifier._createLink('', classes || '');
     var info = Components.Linkifier._linkInfo(anchor);
@@ skipping 81 matching lines @@
     info.icon = icon;
   }
 
   /**
    * @param {string} url
    * @param {string=} text
    * @param {string=} className
    * @param {number=} lineNumber
    * @param {number=} columnNumber
    * @param {boolean=} preventClick
+   * @param {number=} maxLength
    * @return {!Element}
    */
-  static linkifyURL(url, text, className, lineNumber, columnNumber, preventClick) {
+  static linkifyURL(url, text, className, lineNumber, columnNumber, preventClick, maxLength) {

[pfeldman, 2017/05/24 20:16:29]

Do you know who uses prevent click? Maybe it is time to go for the "options"
param with named properties for all the optional params?

[luoe, 2017/05/24 21:58:25]

Only Elements' tree outline and SSP have links that don't open when you click
them.  Param was added here: https://codereview.chromium.org/2519213002

Options object sounds good to me.  That change seems to overshadow this CL's
update to console's linkifier, so I've made a followup CL for it
https://codereview.chromium.org/2902273002/

Lemme know if you'd rather merge it into this CL.

     if (!url || url.trim().toLowerCase().startsWith('javascript:')) {
       var element = createElementWithClass('span', className);
       element.textContent = text || url || Common.UIString('(unknown)');
       return element;
     }
 
     var linkText = text || Bindings.displayNameForURL(url);
     if (typeof lineNumber === 'number' && !text)
       linkText += ':' + (lineNumber + 1);
     var title = linkText !== url ? url : '';
     var link = Components.Linkifier._createLink(
-        linkText, className || '', UI.MaxLengthForDisplayedURLs, title, url, preventClick);
+        linkText, className || '', maxLength || UI.MaxLengthForDisplayedURLs, title, url, preventClick);
     var info = Components.Linkifier._linkInfo(link);
     if (typeof lineNumber === 'number')
       info.lineNumber = lineNumber;
     if (typeof columnNumber === 'number')
       info.columnNumber = columnNumber;
     return link;
   }
 
   /**
    * @param {!Object} revealable
@@ skipping 462 matching lines @@
     contextMenu.appendSeparator();
     contextMenu.appendItem(Common.UIString('Save'), save.bind(null, false));
 
     if (contentProvider instanceof Workspace.UISourceCode) {
       var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (contentProvider);
       if (!uiSourceCode.project().canSetFileContent())
         contextMenu.appendItem(Common.UIString.capitalize('Save ^as...'), save.bind(null, true));
     }
   }
 };