Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2903053002: Removing canvas rendering mode switching feature (Closed)

Created:
3 years, 7 months ago by Justin Novosad
Modified:
3 years, 7 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, haraken, jam, Justin Novosad, kinuko+watch, nasko+codewatch_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing canvas rendering mode switching feature This feature was abandoned. Cleaning out the code BUG=725984 TBR=rkaplow@chromium.org Review-Url: https://codereview.chromium.org/2903053002 Cr-Commit-Position: refs/heads/master@{#474685} Committed: https://chromium.googlesource.com/chromium/src/+/1d09c4ba903d520f3aea3c2fcf1e2cf742828290

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : chromeos build fix #

Patch Set 4 : fix test failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -2118 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/flag_descriptions.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 6 chunks +6 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 2 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 11 chunks +11 lines, -248 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 7 chunks +2 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 2 3 16 chunks +24 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp View 1 chunk +0 lines, -684 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/tools/GeneratePerformanceData.html View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/tools/GeneratePerformanceData.js View 1 chunk +0 lines, -647 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/tools/README.md View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/tools/bench.js View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CanvasHeuristicParameters.h View 1 chunk +109 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h View 1 chunk +0 lines, -216 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
Justin Novosad
3 years, 7 months ago (2017-05-24 18:21:28 UTC) #3
Justin Novosad
jochen: content/ and chrome/ rkaplow: tools/metrics fserb: everything else.
3 years, 7 months ago (2017-05-24 18:28:44 UTC) #8
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-24 19:30:40 UTC) #9
fserb
RIP IsAccelerationOptimalForCanvasContent LGTM https://codereview.chromium.org/2903053002/diff/1/third_party/WebKit/Source/platform/graphics/CanvasHeuristicParameters.h File third_party/WebKit/Source/platform/graphics/CanvasHeuristicParameters.h (right): https://codereview.chromium.org/2903053002/diff/1/third_party/WebKit/Source/platform/graphics/CanvasHeuristicParameters.h#newcode1 third_party/WebKit/Source/platform/graphics/CanvasHeuristicParameters.h:1: // Copyright 2015 The Chromium Authors. ...
3 years, 7 months ago (2017-05-24 20:54:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903053002/60001
3 years, 7 months ago (2017-05-25 14:18:18 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 17:22:42 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1d09c4ba903d520f3aea3c2fcf1e...

Powered by Google App Engine
This is Rietveld 408576698