Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2902863002: Implement EGL context priority if supported, use in VrShell (Closed)

Created:
3 years, 7 months ago by klausw
Modified:
3 years, 7 months ago
Reviewers:
bajones, jbauman
CC:
chromium-reviews, kalyank, feature-vr-reviews_chromium.org, ozone-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement EGL context priority if supported, use in VrShell On devices where the EGL context priority extension is supported, make this available when creating GL contexts, and use it for VrShell's VR compositing. The extension is documented here: https://www.khronos.org/registry/EGL/extensions/IMG/EGL_IMG_context_priority.txt If the extension is not supported, ignore the requested priority. As a special case, assume the extension is present if other VR-specific extensions are available. It was erroneously not reported as present on Daydream devices even though it was implemented, see https://github.com/googlevr/gvr-android-sdk/issues/330 . (This functionality was previously implemented in http://crrev.com/2586803003 but was reverted due to synchronization issues with non-virtualized contexts. In this new version, only VrShell's private native rendering context uses this option, so WebGL can continue using virtualized contexts as before.) BUG=725684 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2902863002 Cr-Commit-Position: refs/heads/master@{#474122} Committed: https://chromium.googlesource.com/chromium/src/+/9f8c6768f7dff7a712449cc3b526ece8d3ad43a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/gl/gl_context.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/gl/gl_context_egl.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
klausw
jbauman@chromium.org: Please review changes in ui/gl (You had previously LGTMed this as part of http://crrev.com/2586803003 ...
3 years, 7 months ago (2017-05-23 22:27:31 UTC) #3
jbauman
ui/gl lgtm
3 years, 7 months ago (2017-05-23 22:31:28 UTC) #6
bajones
On 2017/05/23 22:31:28, jbauman wrote: > ui/gl lgtm vr_shell/ LGTM
3 years, 7 months ago (2017-05-23 22:38:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902863002/1
3 years, 7 months ago (2017-05-24 00:26:49 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 00:32:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9f8c6768f7dff7a712449cc3b526...

Powered by Google App Engine
This is Rietveld 408576698