Milo: Swarming module test coverage

Milo: Swarming module test coverage

This just adds a little more coverage:
* Bad http requests.  Covering good http requests requires a larger refactor.
* Build logs
* Some more build page cases

Now at 71.3%

BUG=712431
Review-Url: https://codereview.chromium.org/2902323002
Committed: https://github.com/luci/luci-go/commit/7e25e6fdad68659a669c8e1569b3eb291639db78

[Ryan Tseng, 2017-05-24 23:28:55]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 23:29:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 23:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 23:35:56]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2017-06-06 22:59:23]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 22:59:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 23:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 23:04:21]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3698741968b86810)
  Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/36987419441f4910)

[Ryan Tseng, 2017-06-07 20:28:55]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 20:28:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 20:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 20:34:06]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/369d10aa78094b10)
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/369d10a969f37810)

[Ryan Tseng, 2017-06-07 22:13:07]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 22:13:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 22:18:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 22:18:23]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/369d7014eb022310)

[Ryan Tseng, 2017-06-07 22:27:19]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 22:27:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 22:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 22:33:13]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2017-06-07 22:50:29]

Description was changed from

==========
Milo: Swarming module test coverage

BUG=
==========

to

==========
Milo: Swarming module test coverage

This just adds a little more coverage:
* Bad http requests.  Covering good http requests requires a larger refactor.
* Build logs
* Some more build page cases

Now at 71.3%

BUG=712431
==========

[Ryan Tseng, 2017-06-07 22:50:29]

hinoka@google.com changed reviewers:
+ nodir@chromium.org

[Ryan Tseng, 2017-06-07 22:52:22]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 22:52:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 22:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 22:58:49]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2017-06-08 00:32:37]

ptal,

I intend to put refactoring in the backlog, with 730835 as tracking bug.

[nodir, 2017-06-08 14:39:12]

lgtm

https://codereview.chromium.org/2902323002/diff/100001/milo/appengine/swarmin...
File milo/appengine/swarming/buildLog_test.go (right):

https://codereview.chromium.org/2902323002/diff/100001/milo/appengine/swarmin...
milo/appengine/swarming/buildLog_test.go:25: c, _ = testclock.UseTime(c,
time.Date(2016, time.March, 14, 11, 0, 0, 0, time.UTC))
any reason we are not using testclock.TestRecentTimeUTC ?

https://codereview.chromium.org/2902323002/diff/100001/milo/appengine/swarmin...
File milo/appengine/swarming/buildinfo_test.go (right):

https://codereview.chromium.org/2902323002/diff/100001/milo/appengine/swarmin...
milo/appengine/swarming/buildinfo_test.go:204: testSvc.req.Tags =
testSvc.req.Tags[1:]
undup line or testSvc.req.Tags = testSvc.req.Tags[2:]

https://codereview.chromium.org/2902323002/diff/100001/milo/appengine/swarmin...
File milo/appengine/swarming/html_test.go (right):

https://codereview.chromium.org/2902323002/diff/100001/milo/appengine/swarmin...
milo/appengine/swarming/html_test.go:15: "github.com/julienschmidt/httprouter"
nit: blank line between luci-go and non-luci-go imports

https://codereview.chromium.org/2902323002/diff/100001/milo/appengine/swarmin...
milo/appengine/swarming/html_test.go:24: .
"github.com/smartystreets/goconvey/convey"
nit: blank line before . imports

https://codereview.chromium.org/2902323002/diff/100001/milo/appengine/swarmin...
milo/appengine/swarming/html_test.go:27: func request(c context.Context, params
map[string]string) *router.Context {
nit: s/request/requestCtx/

https://codereview.chromium.org/2902323002/diff/100001/milo/appengine/swarmin...
milo/appengine/swarming/html_test.go:27: func request(c context.Context, params
map[string]string) *router.Context {
it seems this file would be a bit shorter if params was `... httprouter.Param`
and below you passed httprouter.Params(params). Optional, up to you

[Ryan Tseng, 2017-06-12 20:22:39]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 20:22:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 20:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:29:22]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2017-06-12 20:34:46]

The CQ bit was unchecked by hinoka@google.com

[Ryan Tseng, 2017-06-12 20:39:59]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 20:40:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 20:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:46:42]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2017-06-12 20:47:34]

The CQ bit was checked by hinoka@google.com

[Ryan Tseng, 2017-06-12 20:47:34]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2902323002/#ps140001
(title: "Undo time change")

[commit-bot: I haz the power, 2017-06-12 20:47:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 20:53:37]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1497300454559400,
"parent_rev": "84cdc840d95d717483da83075f99336df4c03e39", "commit_rev":
"7e25e6fdad68659a669c8e1569b3eb291639db78"}

[commit-bot: I haz the power, 2017-06-12 20:53:41]

Description was changed from

==========
Milo: Swarming module test coverage

This just adds a little more coverage:
* Bad http requests.  Covering good http requests requires a larger refactor.
* Build logs
* Some more build page cases

Now at 71.3%

BUG=712431
==========

to

==========
Milo: Swarming module test coverage

This just adds a little more coverage:
* Bad http requests.  Covering good http requests requires a larger refactor.
* Build logs
* Some more build page cases

Now at 71.3%

BUG=712431

Review-Url: https://codereview.chromium.org/2902323002
Committed:
https://github.com/luci/luci-go/commit/7e25e6fdad68659a669c8e1569b3eb291639db78
==========

[commit-bot: I haz the power, 2017-06-12 20:53:43]

Committed patchset #8 (id:140001) as
https://github.com/luci/luci-go/commit/7e25e6fdad68659a669c8e1569b3eb291639db78