Milo: Swarming module test coverage

milo/appengine/swarming/buildLog_test.go

+package swarming
+
+import (
+        "context"
+        "strings"
+        "testing"
+        "time"
+
+        "github.com/luci/gae/impl/memory"
+        "github.com/luci/luci-go/common/clock/testclock"
+
+        . "github.com/smartystreets/goconvey/convey"
+)
+
+var testSvc = &debugSwarmingService{
+        tc: &testCase{
+                name:        "build-patch-failure",
+                swarmResult: "build-patch-failure.swarm",
+                swarmOutput: "build-patch-failure",
+        },
+}
+
+func TestBuildLogs(t *testing.T) {
+        c := context.Background()
+        c, _ = testclock.UseTime(c, time.Date(2016, time.March, 14, 11, 0, 0, 0, time.UTC))

[nodir, 2017/06/08 14:39:12]

any reason we are not using testclock.TestRecentTimeUTC ?

+        c = memory.UseWithAppID(c, "dev~luci-milo")
+        Convey(`Build log tests`, t, func() {
+                _, _, err := swarmingBuildLogImpl(c, testSvc, "12340", "/update_scripts/0/stdout")
+                So(err, ShouldBeNil)
+        })
+        Convey(`List available streams`, t, func() {
+                _, _, err := swarmingBuildLogImpl(c, testSvc, "12340", "/notexist")
+                So(strings.HasPrefix(err.Error(), "stream \"steps/notexist\" not found"), ShouldEqual, true)
+        })
+}