Milo: Swarming module test coverage

milo/appengine/swarming/buildinfo_test.go

 // Copyright 2017 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package swarming
 
 import (
         "fmt"
         "testing"
 
         swarming "github.com/luci/luci-go/common/api/swarming/swarming/v1"
         miloProto "github.com/luci/luci-go/common/proto/milo"
+        "github.com/luci/luci-go/grpc/grpcutil"
         "github.com/luci/luci-go/logdog/api/endpoints/coordinator/logs/v1"
         "github.com/luci/luci-go/logdog/client/coordinator"
         milo "github.com/luci/luci-go/milo/api/proto"
 
         "github.com/luci/gae/impl/memory"
 
         "golang.org/x/net/context"
 
         . "github.com/luci/luci-go/common/testing/assertions"
         . "github.com/smartystreets/goconvey/convey"
 )
 
 type testSwarmingService struct {
         swarmingService
 
         host string
         req  swarming.SwarmingRpcsTaskRequest
         res  swarming.SwarmingRpcsTaskResult
+        out  string
 }
 
 func (sf *testSwarmingService) getHost() string { return sf.host }
 
 func (sf *testSwarmingService) getSwarmingResult(c context.Context, taskID string) (
         *swarming.SwarmingRpcsTaskResult, error) {
 
         return &sf.res, nil
 }
 
 func (sf *testSwarmingService) getSwarmingRequest(c context.Context, taskID string) (
         *swarming.SwarmingRpcsTaskRequest, error) {
 
         return &sf.req, nil
 }
 
+func (sf *testSwarmingService) getTaskOutput(c context.Context, taskID string) (string, error) {
+        return sf.out, nil
+}
+
 func TestBuildInfo(t *testing.T) {
         t.Parallel()
 
         Convey("A testing BuildInfoProvider", t, func() {
                 c := context.Background()
                 c = memory.Use(c)
 
                 testClient := testLogDogClient{}
                 testSvc := testSwarmingService{
                         host: "swarming.example.com",
@@ skipping 128 matching lines @@
                                         Property: []*miloProto.Step_Property{
                                                 {Name: "bar", Value: "log-bar"},
                                         },
                                 },
                                 AnnotationStream: &miloProto.LogdogStream{
                                         Server: "example.com",
                                         Prefix: "swarm/swarming.example.com/12341",
                                         Name:   "annotations",
                                 },
                         })
+
+                        Convey("Will return NotFound if the build is internal", func() {
+                                testSvc.res.Tags = testSvc.res.Tags[1:]
+                                testSvc.req.Tags = testSvc.req.Tags[1:]

[nodir, 2017/06/08 14:39:12]

undup line or testSvc.req.Tags = testSvc.req.Tags[2:]

+                                _, err := bip.GetBuildInfo(c, biReq.GetSwarming(), "testproject")
+                                So(err, ShouldResemble, grpcutil.NotFound)
+                        })
                 })
         })
 }
 
 func TestGetRunID(t *testing.T) {
         t.Parallel()
 
         successes := []struct {
                 taskID    string
                 tryNumber int64
@@ skipping 22 matching lines @@
                 }
 
                 for _, tc := range failures {
                         Convey(fmt.Sprintf("Failes to parse %q / %q (%s)", tc.taskID, tc.tryNumber, tc.err), func() {
                                 _, err := getRunID(tc.taskID, tc.tryNumber)
                                 So(err, ShouldErrLike, tc.err)
                         })
                 }
         })
 }