CoreJIT snapshots without training.

CoreJIT snapshots without training.

Only include OSR and field guards in the features descriptor for JIT code to avoid gen_snapshot and dart having different default values.

Disabled since core snapshots with code break tests with non-default flags for type checks, assertions, strict errors, OSR, or field guards.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/76df24b0762e43af2da0954ddf30d7a9903c9f30

[rmacnak, 2017-05-25 23:12:42]

Description was changed from

==========
Core-jit.
==========

to

==========
CoreJIT snapshots without training.
==========

[rmacnak, 2017-05-25 23:16:56]

Description was changed from

==========
CoreJIT snapshots without training.
==========

to

==========
CoreJIT snapshots without training.

Only include OSR and field guards in the features descriptor for JIT code to
avoid gen_snapshot and dart having different default values.
==========

[rmacnak, 2017-05-25 23:23:01]

Description was changed from

==========
CoreJIT snapshots without training.

Only include OSR and field guards in the features descriptor for JIT code to
avoid gen_snapshot and dart having different default values.
==========

to

==========
CoreJIT snapshots without training.

Only include OSR and field guards in the features descriptor for JIT code to
avoid gen_snapshot and dart having different default values.

Disabled since core snapshots with code break tests with non-default flags for
type checks, assertions, strict errors, OSR, or field guards.
==========

[rmacnak, 2017-05-26 00:37:49]

rmacnak@google.com changed reviewers:
+ asiva@google.com, zra@google.com

[zra, 2017-05-31 17:10:31]

https://codereview.chromium.org/2902313004/diff/40001/runtime/vm/clustered_sn...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2902313004/diff/40001/runtime/vm/clustered_sn...
runtime/vm/clustered_snapshot.cc:1549: OS::Print("C");
leftover debug print?

https://codereview.chromium.org/2902313004/diff/60001/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/2902313004/diff/60001/runtime/bin/BUILD.gn#ne...
runtime/bin/BUILD.gn:13: core_snapshot_kind = "core"
dart_core_snapshot_kind

[rmacnak, 2017-05-31 19:53:01]

https://codereview.chromium.org/2902313004/diff/40001/runtime/vm/clustered_sn...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2902313004/diff/40001/runtime/vm/clustered_sn...
runtime/vm/clustered_snapshot.cc:1549: OS::Print("C");
On 2017/05/31 17:10:31, zra wrote:
> leftover debug print?

Removed.

https://codereview.chromium.org/2902313004/diff/60001/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/2902313004/diff/60001/runtime/bin/BUILD.gn#ne...
runtime/bin/BUILD.gn:13: core_snapshot_kind = "core"
On 2017/05/31 17:10:31, zra wrote:
> dart_core_snapshot_kind

Done.

[zra, 2017-05-31 19:53:51]

lgtm

[rmacnak, 2017-05-31 20:49:17]

Description was changed from

==========
CoreJIT snapshots without training.

Only include OSR and field guards in the features descriptor for JIT code to
avoid gen_snapshot and dart having different default values.

Disabled since core snapshots with code break tests with non-default flags for
type checks, assertions, strict errors, OSR, or field guards.
==========

to

==========
CoreJIT snapshots without training.

Only include OSR and field guards in the features descriptor for JIT code to
avoid gen_snapshot and dart having different default values.

Disabled since core snapshots with code break tests with non-default flags for
type checks, assertions, strict errors, OSR, or field guards.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/76df24b0762e43af2da0954ddf30d7a9903c9f30
==========

[rmacnak, 2017-05-31 20:49:18]

Committed patchset #5 (id:80001) manually as
76df24b0762e43af2da0954ddf30d7a9903c9f30 (presubmit successful).

[siva, 2017-05-31 21:14:16]

lgtm

https://codereview.chromium.org/2902313004/diff/80001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2902313004/diff/80001/runtime/include/dart_ap...
runtime/include/dart_api.h:3346: intptr_t* isolate_snapshot_instructions_size);
The API has grown to have so many options I am wondering is we should define a
structure and pass just one arg

enum SnapshotKind {
  Dart_kNone,
  Dart_kScript,
  ...
};

typedef struct {
  SnapshotKind kind;  
  uint8_t** vm_snapshot_data_buffer;
  intptr_t* vm_snapshot_data_size;
  ....
  ....
  ....
} Dart_SnapshotParams;

DART_EXPORT Dart_Handle Dart_CreateCoreJITSnapshotAsBlobs(Dart_SnapshotParams*
params);

I am also wondering if we can have just one function for all the kinds:
Dart_CreateSnapshot(Dart_SnapshotParams* params);

[siva, 2017-05-31 21:14:16]

lgtm

[rmacnak, 2017-06-01 00:37:05]

https://codereview.chromium.org/2902313004/diff/80001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2902313004/diff/80001/runtime/include/dart_ap...
runtime/include/dart_api.h:3346: intptr_t* isolate_snapshot_instructions_size);
On 2017/05/31 21:14:15, siva wrote:
> The API has grown to have so many options I am wondering is we should define a
> structure and pass just one arg
> 
> enum SnapshotKind {
>   Dart_kNone,
>   Dart_kScript,
>   ...
> };
> 
> typedef struct {
>   SnapshotKind kind;  
>   uint8_t** vm_snapshot_data_buffer;
>   intptr_t* vm_snapshot_data_size;
>   ....
>   ....
>   ....
> } Dart_SnapshotParams;
> 
> DART_EXPORT Dart_Handle Dart_CreateCoreJITSnapshotAsBlobs(Dart_SnapshotParams*
> params);
> 
> I am also wondering if we can have just one function for all the kinds:
> Dart_CreateSnapshot(Dart_SnapshotParams* params);

This seems promising.