Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: runtime/vm/object.cc

Issue 2902313004: CoreJIT snapshots without training. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 2c6422e7d0e5d68d8799ed3ba5034b6b3bc99174..aeab50c73a68f13e50668dddd432638aa54cf98b 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -3570,7 +3570,7 @@ TokenPosition Class::ComputeEndTokenPos() const {
const TokenStream& tkns = TokenStream::Handle(zone, scr.tokens());
if (tkns.IsNull()) {
- ASSERT(Dart::vm_snapshot_kind() == Snapshot::kAppAOT);
+ ASSERT(Dart::vm_snapshot_kind() == Snapshot::kFullAOT);
return TokenPosition::kNoSource;
}
TokenStream::Iterator tkit(zone, tkns, token_pos(),
@@ -7956,7 +7956,7 @@ RawString* Field::InitializingExpression() const {
ASSERT(!scr.IsNull());
const TokenStream& tkns = TokenStream::Handle(zone, scr.tokens());
if (tkns.IsNull()) {
- ASSERT(Dart::vm_snapshot_kind() == Snapshot::kAppAOT);
+ ASSERT(Dart::vm_snapshot_kind() == Snapshot::kFullAOT);
return String::null();
}
TokenStream::Iterator tkit(zone, tkns, token_pos());
@@ -9109,7 +9109,7 @@ RawString* Script::GenerateSource() const {
const TokenStream& token_stream = TokenStream::Handle(tokens());
if (token_stream.IsNull()) {
- ASSERT(Dart::vm_snapshot_kind() == Snapshot::kAppAOT);
+ ASSERT(Dart::vm_snapshot_kind() == Snapshot::kFullAOT);
return String::null();
}
return token_stream.GenerateSource();
@@ -9474,7 +9474,7 @@ void Script::GetTokenLocation(TokenPosition token_pos,
const TokenStream& tkns = TokenStream::Handle(zone, tokens());
if (tkns.IsNull()) {
- ASSERT((Dart::vm_snapshot_kind() == Snapshot::kAppAOT));
+ ASSERT((Dart::vm_snapshot_kind() == Snapshot::kFullAOT));
*line = -1;
if (column != NULL) {
*column = -1;
@@ -9632,7 +9632,7 @@ int32_t Script::SourceFingerprint(TokenPosition start,
RawString* Script::GetLine(intptr_t line_number, Heap::Space space) const {
const String& src = String::Handle(Source());
if (src.IsNull()) {
- ASSERT(Dart::vm_snapshot_kind() == Snapshot::kAppAOT);
+ ASSERT(Dart::vm_snapshot_kind() == Snapshot::kFullAOT);
return Symbols::OptimizedOut().raw();
}
intptr_t relative_line_number = line_number - line_offset();
@@ -9682,7 +9682,7 @@ RawString* Script::GetSnippet(intptr_t from_line,
intptr_t to_column) const {
const String& src = String::Handle(Source());
if (src.IsNull()) {
- ASSERT(Dart::vm_snapshot_kind() == Snapshot::kAppAOT);
+ ASSERT(Dart::vm_snapshot_kind() == Snapshot::kFullAOT);
return Symbols::OptimizedOut().raw();
}
intptr_t length = src.Length();
@@ -11579,7 +11579,7 @@ bool LibraryPrefix::LoadLibrary() const {
}
ASSERT(is_deferred_load());
ASSERT(num_imports() == 1);
- if (Dart::vm_snapshot_kind() == Snapshot::kAppAOT) {
+ if (Dart::vm_snapshot_kind() == Snapshot::kFullAOT) {
// The library list was tree-shaken away.
this->set_is_loaded();
return true;
@@ -13045,7 +13045,7 @@ const char* ICData::ToCString() const {
RawFunction* ICData::Owner() const {
Object& obj = Object::Handle(raw_ptr()->owner_);
if (obj.IsNull()) {
- ASSERT(Dart::vm_snapshot_kind() == Snapshot::kAppAOT);
+ ASSERT(Dart::vm_snapshot_kind() == Snapshot::kFullAOT);
return Function::null();
} else if (obj.IsFunction()) {
return Function::Cast(obj).raw();
@@ -14242,7 +14242,7 @@ RawTypedData* Code::GetDeoptInfoAtPc(uword pc,
uword code_entry = instrs.PayloadStart();
const Array& table = Array::Handle(deopt_info_array());
if (table.IsNull()) {
- ASSERT(Dart::vm_snapshot_kind() == Snapshot::kAppAOT);
+ ASSERT(Dart::vm_snapshot_kind() == Snapshot::kFullAOT);
return TypedData::null();
}
// Linear search for the PC offset matching the target PC.

Powered by Google App Engine
This is Rietveld 408576698