runtime/vm/pages.cc - Issue 2902313004: CoreJIT snapshots without training.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/pages.cc

Issue 2902313004: CoreJIT snapshots without training. (Closed)

Patch Set: . Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/pages.cc

diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc

index beb81891ffcbe2bc6e1f9cbf5e4f95ee79864864..9c52356321181e21b265ba2db60c021b566e4d9c 100644

--- a/runtime/vm/pages.cc

+++ b/runtime/vm/pages.cc

@@ -246,7 +246,7 @@ HeapPage* PageSpace::AllocatePage(HeapPage::PageType type) {

} else {

// Should not allocate executable pages when running from a precompiled

// snapshot.

- ASSERT(Dart::vm_snapshot_kind() != Snapshot::kAppAOT);

+ ASSERT(Dart::vm_snapshot_kind() != Snapshot::kFullAOT);

if (exec_pages_ == NULL) {

exec_pages_ = page;