Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1604)

Unified Diff: runtime/vm/benchmark_test.cc

Issue 2902313004: CoreJIT snapshots without training. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/benchmark_test.cc
diff --git a/runtime/vm/benchmark_test.cc b/runtime/vm/benchmark_test.cc
index 856228de19ad2792a2be7388c5897efb07ce9f26..3882e56132aa8ef398baae83a8239e472ba978fc 100644
--- a/runtime/vm/benchmark_test.cc
+++ b/runtime/vm/benchmark_test.cc
@@ -521,13 +521,13 @@ BENCHMARK_SIZE(CoreSnapshotSize) {
Api::CheckAndFinalizePendingClasses(thread);
// Write snapshot with object content.
- FullSnapshotWriter writer(Snapshot::kCore, &vm_snapshot_data_buffer,
+ FullSnapshotWriter writer(Snapshot::kFull, &vm_snapshot_data_buffer,
&isolate_snapshot_data_buffer, &malloc_allocator,
NULL, NULL /* image_writer */);
writer.WriteFullSnapshot();
const Snapshot* snapshot =
Snapshot::SetupFromBuffer(isolate_snapshot_data_buffer);
- ASSERT(snapshot->kind() == Snapshot::kCore);
+ ASSERT(snapshot->kind() == Snapshot::kFull);
benchmark->set_score(snapshot->length());
free(vm_snapshot_data_buffer);
@@ -559,13 +559,13 @@ BENCHMARK_SIZE(StandaloneSnapshotSize) {
Api::CheckAndFinalizePendingClasses(thread);
// Write snapshot with object content.
- FullSnapshotWriter writer(Snapshot::kCore, &vm_snapshot_data_buffer,
+ FullSnapshotWriter writer(Snapshot::kFull, &vm_snapshot_data_buffer,
&isolate_snapshot_data_buffer, &malloc_allocator,
NULL, NULL /* image_writer */);
writer.WriteFullSnapshot();
const Snapshot* snapshot =
Snapshot::SetupFromBuffer(isolate_snapshot_data_buffer);
- ASSERT(snapshot->kind() == Snapshot::kCore);
+ ASSERT(snapshot->kind() == Snapshot::kFull);
benchmark->set_score(snapshot->length());
free(vm_snapshot_data_buffer);

Powered by Google App Engine
This is Rietveld 408576698