third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js - Issue 2902273002: DevTools: convert linkifyURL params into options object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 2902273002: DevTools: convert linkifyURL params into options object (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('K') | « third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

index 725c84c3786da45fa9d9536fd0912e03e6a12a53..11dedc028384783519fb69fb148820d18920fb7a 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

@@ -261,7 +261,7 @@ Resources.ServiceWorkersView.Section = class {

var scriptElement = this._section.appendField(Common.UIString('Source'));

scriptElement.removeChildren();

var fileName = Common.ParsedURL.extractName(active.scriptURL);

- scriptElement.appendChild(Components.Linkifier.linkifyURL(active.scriptURL, fileName));

+ scriptElement.appendChild(Components.Linkifier.linkifyURL({url: active.scriptURL, text: fileName}));

scriptElement.createChild('div', 'report-field-value-subtitle').textContent =

Common.UIString('Received %s', new Date(active.scriptResponseTime * 1000).toLocaleString());