Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

Issue 2902273002: DevTools: convert linkifyURL params into options object (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
index 2354b93bb8ac1c9372217fea7050c953c3e7949b..26ada1db2844fb8c5cdb1622a64b2d6d6743aa29 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
@@ -95,7 +95,7 @@ Resources.AppManifestView = class extends UI.VBox {
this._emptyView.hideWidget();
this._reportView.showWidget();
- this._reportView.setURL(Components.Linkifier.linkifyURL(url));
+ this._reportView.setURL(Components.Linkifier.linkifyURL({url: url}));
this._errorsSection.clearContent();
this._errorsSection.element.classList.toggle('hidden', !errors.length);
for (var error of errors) {
@@ -115,8 +115,8 @@ Resources.AppManifestView = class extends UI.VBox {
this._startURLField.removeChildren();
var startURL = stringProperty('start_url');
if (startURL) {
- this._startURLField.appendChild(Components.Linkifier.linkifyURL(
- /** @type {string} */ (Common.ParsedURL.completeURL(url, startURL)), startURL));
+ var completeURL = /** @type {string} */ (Common.ParsedURL.completeURL(url, startURL));
+ this._startURLField.appendChild(Components.Linkifier.linkifyURL({url: completeURL, text: startURL}));
}
this._themeColorSwatch.classList.toggle('hidden', !stringProperty('theme_color'));

Powered by Google App Engine
This is Rietveld 408576698