Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2902273002: DevTools: convert linkifyURL params into options object (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 9202ce2b689124bea4772458b3189c5749e921c8..1237109f3b925387ee629db0049648d448990ca5 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -638,7 +638,7 @@ Timeline.TimelineUIUtils = class {
case recordType.ResourceFinish:
var url = TimelineModel.TimelineData.forEvent(event).url;
if (url)
- details = Components.Linkifier.linkifyURL(url);
+ details = Components.Linkifier.linkifyURL({url: url});
break;
case recordType.FunctionCall:
case recordType.JSFrame:
@@ -790,7 +790,7 @@ Timeline.TimelineUIUtils = class {
case recordTypes.ResourceFinish:
url = timelineData.url;
if (url)
- contentHelper.appendElementRow(Common.UIString('Resource'), Components.Linkifier.linkifyURL(url));
+ contentHelper.appendElementRow(Common.UIString('Resource'), Components.Linkifier.linkifyURL({url: url}));
if (eventData['requestMethod'])
contentHelper.appendTextRow(Common.UIString('Request Method'), eventData['requestMethod']);
if (typeof eventData['statusCode'] === 'number')
@@ -839,12 +839,14 @@ Timeline.TimelineUIUtils = class {
relatedNodeLabel = Common.UIString('Owner Element');
url = timelineData.url;
if (url)
- contentHelper.appendElementRow(Common.UIString('Image URL'), Components.Linkifier.linkifyURL(url));
+ contentHelper.appendElementRow(Common.UIString('Image URL'), Components.Linkifier.linkifyURL({url: url}));
break;
case recordTypes.ParseAuthorStyleSheet:
url = eventData['styleSheetUrl'];
- if (url)
- contentHelper.appendElementRow(Common.UIString('Stylesheet URL'), Components.Linkifier.linkifyURL(url));
+ if (url) {
+ contentHelper.appendElementRow(
+ Common.UIString('Stylesheet URL'), Components.Linkifier.linkifyURL({url: url}));
+ }
break;
case recordTypes.UpdateLayoutTree: // We don't want to see default details.
case recordTypes.RecalculateStyles:
@@ -1107,7 +1109,7 @@ Timeline.TimelineUIUtils = class {
const duration = request.endTime - (request.startTime || -Infinity);
if (request.url)
- contentHelper.appendElementRow(Common.UIString('URL'), Components.Linkifier.linkifyURL(request.url));
+ contentHelper.appendElementRow(Common.UIString('URL'), Components.Linkifier.linkifyURL({url: request.url}));
Timeline.TimelineUIUtils._maybeAppendProductToDetails(contentHelper, badgePool, request.url);
if (isFinite(duration))
contentHelper.appendTextRow(Common.UIString('Duration'), Number.millisToString(duration, true));

Powered by Google App Engine
This is Rietveld 408576698