Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2902273002: DevTools: convert linkifyURL params into options object (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index 659c86b853a5c31bf84f5fd32498d35bee5923f3..acd83ce35fbadb5107a44c013d6c185721f59a95 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -929,9 +929,12 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
case SDK.NetworkRequest.InitiatorType.Parser:
cell.title = initiator.url + ':' + (initiator.lineNumber + 1);
var uiSourceCode = Workspace.workspace.uiSourceCodeForURL(initiator.url);
- cell.appendChild(Components.Linkifier.linkifyURL(
- initiator.url, uiSourceCode ? uiSourceCode.displayName() : undefined, '', initiator.lineNumber,
- initiator.columnNumber));
+ cell.appendChild(Components.Linkifier.linkifyURL({
+ url: initiator.url,
+ text: uiSourceCode ? uiSourceCode.displayName() : undefined,
+ lineNumber: initiator.lineNumber,
+ columnNumber: initiator.columnNumber
+ }));
this._appendSubtitle(cell, Common.UIString('Parser'));
break;
@@ -943,7 +946,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
cell.appendChild(
Components.Linkifier.linkifyRevealable(redirectSource, Bindings.displayNameForURL(redirectSource.url())));
} else {
- cell.appendChild(Components.Linkifier.linkifyURL(redirectSource.url()));
+ cell.appendChild(Components.Linkifier.linkifyURL({url: redirectSource.url()}));
}
this._appendSubtitle(cell, Common.UIString('Redirect'));
break;

Powered by Google App Engine
This is Rietveld 408576698