Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2901853002: Improve various old tests. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
Reviewers:
Johnni Winther, kasperl
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -94 lines) Patch
M tests/language/black_listed_test.dart View 1 chunk +125 lines, -67 lines 0 comments Download
M tests/language/const_error_multiply_initialized_test.dart View 1 chunk +27 lines, -16 lines 0 comments Download
M tests/language/named_parameters_aggregated_test.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/language/ref_before_declaration_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/static_parameter_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 7 months ago (2017-05-23 14:42:20 UTC) #2
Johnni Winther
lgtm
3 years, 7 months ago (2017-05-24 08:00:52 UTC) #3
ahe
3 years, 7 months ago (2017-05-24 09:46:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1cfb242321655fa34ecc1a28525aaada8dcc2650.

Powered by Google App Engine
This is Rietveld 408576698