Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2904483002: Improve analysis coverage. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Support Windows. #

Patch Set 3 : Update dart2js testing.json and make it actually work on Windows. #

Patch Set 4 : Use --batch to work around long command line. #

Patch Set 5 : Exclude files with spaces. #

Patch Set 6 : Ignore another file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -64 lines) Patch
M pkg/compiler/testing.json View 1 2 3 4 5 1 chunk +111 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 1 2 1 chunk +19 lines, -29 lines 0 comments Download
M pkg/testing/lib/src/analyze.dart View 1 2 3 4 5 chunks +123 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahe
3 years, 7 months ago (2017-05-23 11:04:59 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2904483002/diff/1/pkg/testing/lib/src/analyze.dart File pkg/testing/lib/src/analyze.dart (right): https://codereview.chromium.org/2904483002/diff/1/pkg/testing/lib/src/analyze.dart#newcode266 pkg/testing/lib/src/analyze.dart:266: "git", <String>[command]..addAll(arguments), This doesn't work on Windows (missing ...
3 years, 7 months ago (2017-05-23 14:02:53 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/2904483002/diff/1/pkg/testing/lib/src/analyze.dart File pkg/testing/lib/src/analyze.dart (right): https://codereview.chromium.org/2904483002/diff/1/pkg/testing/lib/src/analyze.dart#newcode266 pkg/testing/lib/src/analyze.dart:266: "git", <String>[command]..addAll(arguments), On 2017/05/23 14:02:53, Johnni ...
3 years, 7 months ago (2017-05-24 09:12:53 UTC) #4
Johnni Winther
lgtm
3 years, 7 months ago (2017-05-24 13:51:59 UTC) #5
ahe
3 years, 7 months ago (2017-05-24 13:52:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
ddf5fc23f1ee639294cbc32cf24c66e900949587 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698