Fix various semantic nits that Fasta will detect.

Fix various semantic nits that Fasta will detect.

R=johnniwinther@google.com, paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/b6a78795e4e264fca4e816f6c83a3b05905767de

[ahe, 2017-05-23 14:44:26]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, scheglov@google.com

[ahe, 2017-05-23 14:44:27]

https://codereview.chromium.org/2897003003/diff/1/pkg/front_end/test/src/incr...
File pkg/front_end/test/src/incremental/mock_sdk.dart (right):

https://codereview.chromium.org/2897003003/diff/1/pkg/front_end/test/src/incr...
pkg/front_end/test/src/incremental/mock_sdk.dart:28: const Object();
A const constructor can't have a body.

https://codereview.chromium.org/2897003003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/2897003003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:2353: message =
tryStringifyException(ex);
Already defined and used above in this scope.

https://codereview.chromium.org/2897003003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/js_number.dart (right):

https://codereview.chromium.org/2897003003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/js_number.dart:223: result = JS('String', '#',
match[1]);
Already used above in this scope.

[Paul Berry, 2017-05-23 15:52:17]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2017-05-23 15:52:17]

lgtm

[scheglov, 2017-05-23 16:05:11]

LGTM

[Johnni Winther, 2017-05-24 08:02:10]

lgtm

[ahe, 2017-05-24 09:43:24]

Description was changed from

==========
Fix various semantic nits that Fasta will detect.
==========

to

==========
Fix various semantic nits that Fasta will detect.

R=johnniwinther@google.com, paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b6a78795e4e264fca4e816f6c83a3b05905767de
==========

[ahe, 2017-05-24 09:43:25]

Committed patchset #1 (id:1) manually as
b6a78795e4e264fca4e816f6c83a3b05905767de (presubmit successful).