Prepare for development branch by updating externally-used API.

Prepare for development branch by updating externally-used API.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/61d855bb47be69e179e6464238b80547f58595e0

[ahe, 2017-05-23 14:58:04]

Patchset #1 (id:1) has been deleted

[ahe, 2017-05-23 15:04:23]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, scheglov@google.com

[ahe, 2017-05-23 15:04:25]

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:315: if (error != null) {
This is currently dead code as error is always null.

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/loader.dart (right):

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/loader.dart:47: {Uri fileUri, LibraryBuilder
accessor}) {
The accessor will be used to ensure that private dart libraries, such as
dart:_builtin can't be imported by user code.

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scope.dart (right):

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scope.dart:177: return null;
Will eventually return an InputError if the name is already used in this scope.

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/unhandled_listener.dart (right):

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/unhandled_listener.dart:92: void
prepareInitializers() {
Moving this method here allows me to remove it from ast_builder.dart now.

[scheglov, 2017-05-23 16:14:45]

lgtm

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/loader.dart (right):

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/loader.dart:47: {Uri fileUri, LibraryBuilder
accessor}) {
Please document new parameters.

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scope.dart (right):

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scope.dart:171: String name, Builder builder, int
charOffset, Uri fileUri) {
Please document the method and meaning of the parameters.

[ahe, 2017-05-23 21:05:01]

Thank you, Konstatin. I appreciate that you ask for documentation comments, I
need help remembering to add them (also for my own benefit).

[ahe, 2017-05-24 10:53:40]

Comments added.

[ahe, 2017-05-24 10:54:20]

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/loader.dart (right):

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/loader.dart:47: {Uri fileUri, LibraryBuilder
accessor}) {
On 2017/05/23 16:14:45, scheglov wrote:
> Please document new parameters.

Done.

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scope.dart (right):

https://codereview.chromium.org/2898183002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scope.dart:171: String name, Builder builder, int
charOffset, Uri fileUri) {
On 2017/05/23 16:14:45, scheglov wrote:
> Please document the method and meaning of the parameters.

Done.

[ahe, 2017-05-24 12:32:52]

Description was changed from

==========
Prepare for development branch by updating externally-used API.
==========

to

==========
Prepare for development branch by updating externally-used API.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/61d855bb47be69e179e6464238b80547f58595e0
==========

[ahe, 2017-05-24 12:32:53]

Committed patchset #3 (id:60001) manually as
61d855bb47be69e179e6464238b80547f58595e0 (presubmit successful).