Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 2901773006: Reland of android: Move most hooks to target_os-specific section. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
jbudorick, amineer
CC:
chromium-reviews, scottmg
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of android: Move most hooks to target_os-specific section. (patchset #1 id:1 of https://codereview.chromium.org/2900523002/ ) Reason for revert: The underlying issue was fixed. Original issue's description: > Revert of android: Move most hooks to target_os-specific section. (patchset #3 id:40001 of https://codereview.chromium.org/2889323003/ ) > > Reason for revert: > Causes build failures. > > BUG=724813 > > Original issue's description: > > android: Move most hooks to target_os-specific section. > > > > gclient recently learned about os-specific hooks, so let's make it so > > that only people working on android need to run the many, many > > android-specific hooks. > > > > No intended behavior change. This depends on your gclient being > > up-to-date -- it's supposed to auto-update every time you run > > `gclient`, but that sometimes doesn't work. If you see issues > > after this, `cd ~/src/depot_tools` and `git log` to verify > > that your depot_tools is up-to-date (if it isn't, it's probably > > easiest to delete and re-checkout depot_tools). > > > > BUG=none > > > > Review-Url: https://codereview.chromium.org/2889323003 > > Cr-Commit-Position: refs/heads/master@{#473247} > > Committed: https://chromium.googlesource.com/chromium/src/+/e11217d349cd215cde35f3dde1174a149303ac9c > > TBR=jbudorick@chromium.org,thakis@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=none > > Review-Url: https://codereview.chromium.org/2900523002 > Cr-Commit-Position: refs/heads/master@{#473446} > Committed: https://chromium.googlesource.com/chromium/src/+/44faa4c06bee5c2bc6f5588dad8e75dc93e5de57 TBR=jbudorick@chromium.org,amineer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724813 Review-Url: https://codereview.chromium.org/2901773006 Cr-Commit-Position: refs/heads/master@{#474292} Committed: https://chromium.googlesource.com/chromium/src/+/973bb243e5b37af1b8f8b34f44f2643a1aca7e3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -263 lines) Patch
M DEPS View 6 chunks +266 lines, -263 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
Created Reland of android: Move most hooks to target_os-specific section.
3 years, 7 months ago (2017-05-24 14:07:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901773006/1
3 years, 7 months ago (2017-05-24 14:08:04 UTC) #3
jbudorick
lgtm stamp
3 years, 7 months ago (2017-05-24 14:09:12 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 15:27:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/973bb243e5b37af1b8f8b34f44f2...

Powered by Google App Engine
This is Rietveld 408576698