Revert of android: Move most hooks to target_os-specific section.

Revert of android: Move most hooks to target_os-specific section. (patchset #3 id:40001 of https://codereview.chromium.org/2889323003/ )

Reason for revert:
Causes build failures.

BUG=724813
Original issue's description:
> android: Move most hooks to target_os-specific section.
> 
> gclient recently learned about os-specific hooks, so let's make it so
> that only people working on android need to run the many, many
> android-specific hooks.
> 
> No intended behavior change.  This depends on your gclient being
> up-to-date -- it's supposed to auto-update every time you run
> `gclient`, but that sometimes doesn't work.  If you see issues
> after this, `cd ~/src/depot_tools` and `git log` to verify
> that your depot_tools is up-to-date (if it isn't, it's probably
> easiest to delete and re-checkout depot_tools).
> 
> BUG=none
> 
> Review-Url: https://codereview.chromium.org/2889323003
> Cr-Commit-Position: refs/heads/master@{#473247}
> Committed: https://chromium.googlesource.com/chromium/src/+/e11217d349cd215cde35f3dde1174a149303ac9c

TBR=jbudorick@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none

Review-Url: https://codereview.chromium.org/2900523002
Cr-Commit-Position: refs/heads/master@{#473446}
Committed: https://chromium.googlesource.com/chromium/src/+/44faa4c06bee5c2bc6f5588dad8e75dc93e5de57

[amineer, 2017-05-20 18:23:35]

The CQ bit was checked by amineer@chromium.org

[amineer, 2017-05-20 18:23:36]

Created Revert of android: Move most hooks to target_os-specific section.

[commit-bot: I haz the power, 2017-05-20 18:23:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-05-20 19:24:22]

On 2017/05/20 18:23:43, commit-bot: I haz the power wrote:
> CQ is trying da patch.
> 
> Follow status at:
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

This seems to break some internal bot that's apparently configured differently
than all the other bots we have. Can you try fixing your bot's config instead?

[amineer, 2017-05-20 19:52:34]

On 2017/05/20 19:24:22, Nico wrote:
> On 2017/05/20 18:23:43, commit-bot: I haz the power wrote:
> > CQ is trying da patch.
> > 
> > Follow status at:
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> This seems to break some internal bot that's apparently configured differently
> than all the other bots we have. Can you try fixing your bot's config instead?

This internal bot is our official release builder and it's critical we're able
to get a build out and shipped by first thing Monday, so no - we can't fix that
instead (unless you want to figure it out today and get a test build out by
tomorrow to prove it works).  I'm happy to discuss tweaking our bot's config
later, but we can't leave this broken right now.

[Nico, 2017-05-20 19:55:31]

Ok, please let me know once you got it in a shape where I can reland this.

On May 20, 2017 3:52 PM, <amineer@chromium.org> wrote:

> On 2017/05/20 19:24:22, Nico wrote:
> > On 2017/05/20 18:23:43, commit-bot: I haz the power wrote:
> > > CQ is trying da patch.
> > >
> > > Follow status at:
> > >
> >
> https://chromium-cq-status.appspot.com/v2/patch-status/
> codereview.chromium.org/2900523002/1
> >
> > This seems to break some internal bot that's apparently configured
> differently
> > than all the other bots we have. Can you try fixing your bot's config
> instead?
>
> This internal bot is our official release builder and it's critical we're
> able
> to get a build out and shipped by first thing Monday, so no - we can't fix
> that
> instead (unless you want to figure it out today and get a test build out by
> tomorrow to prove it works). I'm happy to discuss tweaking our bot's config
> later, but we can't leave this broken right now.
>
> https://codereview.chromium.org/2900523002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-05-20 19:57:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495304615720340, "parent_rev":
"21e6d26f4a46684deafc43ff9294974bc1b4ed05", "commit_rev":
"44faa4c06bee5c2bc6f5588dad8e75dc93e5de57"}

[commit-bot: I haz the power, 2017-05-20 19:58:08]

Description was changed from

==========
Revert of android: Move most hooks to target_os-specific section. (patchset #3
id:40001 of https://codereview.chromium.org/2889323003/ )

Reason for revert:
Causes build failures.

BUG=724813

Original issue's description:
> android: Move most hooks to target_os-specific section.
> 
> gclient recently learned about os-specific hooks, so let's make it so
> that only people working on android need to run the many, many
> android-specific hooks.
> 
> No intended behavior change.  This depends on your gclient being
> up-to-date -- it's supposed to auto-update every time you run
> `gclient`, but that sometimes doesn't work.  If you see issues
> after this, `cd ~/src/depot_tools` and `git log` to verify
> that your depot_tools is up-to-date (if it isn't, it's probably
> easiest to delete and re-checkout depot_tools).
> 
> BUG=none
> 
> Review-Url: https://codereview.chromium.org/2889323003
> Cr-Commit-Position: refs/heads/master@{#473247}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e11217d349cd215cde35f3dde117...

TBR=jbudorick@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none
==========

to

==========
Revert of android: Move most hooks to target_os-specific section. (patchset #3
id:40001 of https://codereview.chromium.org/2889323003/ )

Reason for revert:
Causes build failures.

BUG=724813

Original issue's description:
> android: Move most hooks to target_os-specific section.
> 
> gclient recently learned about os-specific hooks, so let's make it so
> that only people working on android need to run the many, many
> android-specific hooks.
> 
> No intended behavior change.  This depends on your gclient being
> up-to-date -- it's supposed to auto-update every time you run
> `gclient`, but that sometimes doesn't work.  If you see issues
> after this, `cd ~/src/depot_tools` and `git log` to verify
> that your depot_tools is up-to-date (if it isn't, it's probably
> easiest to delete and re-checkout depot_tools).
> 
> BUG=none
> 
> Review-Url: https://codereview.chromium.org/2889323003
> Cr-Commit-Position: refs/heads/master@{#473247}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e11217d349cd215cde35f3dde117...

TBR=jbudorick@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none

Review-Url: https://codereview.chromium.org/2900523002
Cr-Commit-Position: refs/heads/master@{#473446}
Committed:
https://chromium.googlesource.com/chromium/src/+/44faa4c06bee5c2bc6f5588dad8e...
==========

[commit-bot: I haz the power, 2017-05-20 19:58:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44faa4c06bee5c2bc6f5588dad8e...

[Nico, 2017-05-24 14:07:48]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2901773006/ by thakis@chromium.org.

The reason for reverting is: The underlying issue was fixed..