Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2889323003: android: Move most hooks to target_os-specific section. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, scottmg
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Move most hooks to target_os-specific section. gclient recently learned about os-specific hooks, so let's make it so that only people working on android need to run the many, many android-specific hooks. No intended behavior change. This depends on your gclient being up-to-date -- it's supposed to auto-update every time you run `gclient`, but that sometimes doesn't work. If you see issues after this, `cd ~/src/depot_tools` and `git log` to verify that your depot_tools is up-to-date (if it isn't, it's probably easiest to delete and re-checkout depot_tools). BUG=none Review-Url: https://codereview.chromium.org/2889323003 Cr-Commit-Position: refs/heads/master@{#473247} Committed: https://chromium.googlesource.com/chromium/src/+/e11217d349cd215cde35f3dde1174a149303ac9c

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : 1 more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -263 lines) Patch
M DEPS View 1 2 6 chunks +266 lines, -263 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Nico
3 years, 7 months ago (2017-05-19 15:30:30 UTC) #6
jbudorick
!!!! lgtm
3 years, 7 months ago (2017-05-19 15:41:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889323003/20001
3 years, 7 months ago (2017-05-19 15:49:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889323003/40001
3 years, 7 months ago (2017-05-19 15:53:17 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/e11217d349cd215cde35f3dde1174a149303ac9c
3 years, 7 months ago (2017-05-19 18:09:54 UTC) #16
amineer
3 years, 7 months ago (2017-05-20 18:23:35 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2900523002/ by amineer@chromium.org.

The reason for reverting is: Causes build failures.

BUG=724813.

Powered by Google App Engine
This is Rietveld 408576698