Replaced NavigationContext::IsErrorPage with NavigationContext::GetError

Replaced NavigationContext::IsErrorPage with NavigationContext::GetError

This new API will allow removing
-[CRWNativeContentProvider controllerForURL:withError:isPost:] callback
and replacing it with general purpose
WebStateObserver::DidFinishNavigation that takes NavigationContext.

BUG=725241
TBR=droger@chromium.org

Review-Url: https://codereview.chromium.org/2901633002
Cr-Commit-Position: refs/heads/master@{#473728}
Committed: https://chromium.googlesource.com/chromium/src/+/0417cd2f912497f083c13701f423fef5a6ce34a8

[Eugene But (OOO till 7-30), 2017-05-22 21:48:06]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 21:48:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 22:03:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 22:03:03]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-22 22:29:09]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[kkhorimoto, 2017-05-22 22:39:09]

lgtm

[Eugene But (OOO till 7-30), 2017-05-22 22:41:26]

Description was changed from

==========
Replaced NavigationContext::IsErrorPage with NavigationContext::GetError

This new API will allow removing
-[CRWNativeContentProvider controllerForURL:withError:isPost:] callback
and replacing it with general purpose
WebStateObserver::DidFinishNavigation that takes NavigationContext.

BUG=725241
==========

to

==========
Replaced NavigationContext::IsErrorPage with NavigationContext::GetError

This new API will allow removing
-[CRWNativeContentProvider controllerForURL:withError:isPost:] callback
and replacing it with general purpose
WebStateObserver::DidFinishNavigation that takes NavigationContext.

BUG=725241
TBR=droger@chromium.org
==========

[Eugene But (OOO till 7-30), 2017-05-22 22:41:26]

eugenebut@chromium.org changed reviewers:
+ droger@chromium.org

[Eugene But (OOO till 7-30), 2017-05-22 22:42:02]

Thanks for a quick review! TBRing droger@ for components/translate OWNERS

[Eugene But (OOO till 7-30), 2017-05-22 22:42:06]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-05-22 22:42:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 22:48:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495492926488010, "parent_rev":
"29035633ff21733359d2c81106aa8ef0b6cf77a4", "commit_rev":
"0417cd2f912497f083c13701f423fef5a6ce34a8"}

[commit-bot: I haz the power, 2017-05-22 22:48:28]

Description was changed from

==========
Replaced NavigationContext::IsErrorPage with NavigationContext::GetError

This new API will allow removing
-[CRWNativeContentProvider controllerForURL:withError:isPost:] callback
and replacing it with general purpose
WebStateObserver::DidFinishNavigation that takes NavigationContext.

BUG=725241
TBR=droger@chromium.org
==========

to

==========
Replaced NavigationContext::IsErrorPage with NavigationContext::GetError

This new API will allow removing
-[CRWNativeContentProvider controllerForURL:withError:isPost:] callback
and replacing it with general purpose
WebStateObserver::DidFinishNavigation that takes NavigationContext.

BUG=725241
TBR=droger@chromium.org

Review-Url: https://codereview.chromium.org/2901633002
Cr-Commit-Position: refs/heads/master@{#473728}
Committed:
https://chromium.googlesource.com/chromium/src/+/0417cd2f912497f083c13701f423...
==========

[commit-bot: I haz the power, 2017-05-22 22:48:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0417cd2f912497f083c13701f423...