ios/web/web_state/web_state_impl_unittest.mm - Issue 2901633002: Replaced NavigationContext::IsErrorPage with NavigationContext::GetError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/web_state_impl_unittest.mm

Issue 2901633002: Replaced NavigationContext::IsErrorPage with NavigationContext::GetError (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/web_state_impl_unittest.mm

diff --git a/ios/web/web_state/web_state_impl_unittest.mm b/ios/web/web_state/web_state_impl_unittest.mm

index 609abe70d09abea97c73d53fbfbfeb429979f1a3..58dee9b31d396ba8bd7f8c0f22285fe7a79b5335 100644

--- a/ios/web/web_state/web_state_impl_unittest.mm

+++ b/ios/web/web_state/web_state_impl_unittest.mm

@@ -22,12 +22,11 @@

#include "ios/web/public/test/web_test.h"

#import "ios/web/public/web_state/context_menu_params.h"

#include "ios/web/public/web_state/global_web_state_observer.h"

-#include "ios/web/public/web_state/navigation_context.h"

#import "ios/web/public/web_state/web_state_delegate.h"

#include "ios/web/public/web_state/web_state_observer.h"

#import "ios/web/public/web_state/web_state_policy_decider.h"

#include "ios/web/web_state/global_web_state_event_tracker.h"

-#include "ios/web/web_state/navigation_context_impl.h"

+#import "ios/web/web_state/navigation_context_impl.h"

#import "ios/web/web_state/ui/crw_web_controller.h"

#include "net/http/http_response_headers.h"

#include "net/http/http_util.h"

@@ -360,7 +359,7 @@ TEST_F(WebStateImplTest, ObserverTest) {

observer->did_finish_navigation_info()->context.get();

EXPECT_EQ(context->GetUrl(), actual_context->GetUrl());

EXPECT_FALSE(actual_context->IsSameDocument());

- EXPECT_FALSE(actual_context->IsErrorPage());

+ EXPECT_FALSE(actual_context->GetError());

EXPECT_FALSE(actual_context->GetResponseHeaders());

// Test that DidStartNavigation() is called.

@@ -371,7 +370,7 @@ TEST_F(WebStateImplTest, ObserverTest) {

actual_context = observer->did_start_navigation_info()->context.get();

EXPECT_EQ(context->GetUrl(), actual_context->GetUrl());

EXPECT_FALSE(actual_context->IsSameDocument());

- EXPECT_FALSE(actual_context->IsErrorPage());

+ EXPECT_FALSE(actual_context->GetError());

EXPECT_FALSE(actual_context->GetResponseHeaders());

// Test that NavigationItemsPruned() is called.