ios/web/web_state/ui/crw_web_controller.mm - Issue 2901633002: Replaced NavigationContext::IsErrorPage with NavigationContext::GetError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2901633002: Replaced NavigationContext::IsErrorPage with NavigationContext::GetError (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index afdb77c98861e546d87dddd7d88a9c488cd20ee7..1b63e28bba76b9d855eb34f9a7a5f5ebbadbe8a2 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -81,7 +81,7 @@

#import "ios/web/web_state/js/crw_js_plugin_placeholder_manager.h"

#import "ios/web/web_state/js/crw_js_post_request_loader.h"

#import "ios/web/web_state/js/crw_js_window_id_manager.h"

-#include "ios/web/web_state/navigation_context_impl.h"

+#import "ios/web/web_state/navigation_context_impl.h"

#import "ios/web/web_state/page_viewport_state.h"

#import "ios/web/web_state/ui/crw_context_menu_controller.h"

#import "ios/web/web_state/ui/crw_swipe_recognizer_provider.h"

@@ -3102,7 +3102,7 @@ registerLoadRequestForURL:(const GURL&)requestURL

web::NavigationContextImpl* navigationContext =

[_navigationStates contextForNavigation:navigation];

- navigationContext->SetIsErrorPage(true);

+ navigationContext->SetError(error);

// Handles Frame Load Interrupted errors from WebView.

if ([error.domain isEqual:base::SysUTF8ToNSString(web::kWebKitErrorDomain)] &&