Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: base/prefs/pref_notifier_impl.h

Issue 290083006: Store a stacktrace of PrefService destruction in PrefChangeRegistrar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor improvements Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/prefs/pref_notifier_impl.h
diff --git a/base/prefs/pref_notifier_impl.h b/base/prefs/pref_notifier_impl.h
index 655203d06dbc767bdbff76bb569ebe8380a82f95..6234896f5ab42fd10c9c144b7d5a00195982dceb 100644
--- a/base/prefs/pref_notifier_impl.h
+++ b/base/prefs/pref_notifier_impl.h
@@ -39,6 +39,11 @@ class BASE_PREFS_EXPORT PrefNotifierImpl
void SetPrefService(PrefService* pref_service);
+ // PrefNotifier overrides.
engedy 2014/05/16 15:19:58 I might be missing something, but could we not jus
battre 2014/05/16 15:58:37 Done. I need to cast at the caller site now, but t
+ // TODO(battre): Delete this. See crbug.com/373435.
+ virtual void SetPrefServiceDestructionTrace(
+ const std::string& stacktrace) OVERRIDE;
+
protected:
// PrefNotifier overrides.
virtual void OnPreferenceChanged(const std::string& pref_name) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698