Store a stacktrace of PrefService destruction in PrefChangeRegistrar

base/prefs/pref_notifier_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PREFS_PREF_NOTIFIER_IMPL_H_
 #define BASE_PREFS_PREF_NOTIFIER_IMPL_H_
 
 #include <list>
 #include <string>
 
@@ skipping 21 matching lines @@
   void AddPrefObserver(const char* path, PrefObserver* observer);
   void RemovePrefObserver(const char* path, PrefObserver* observer);
 
   // We run the callback once, when initialization completes. The bool
   // parameter will be set to true for successful initialization,
   // false for unsuccessful.
   void AddInitObserver(base::Callback<void(bool)> observer);
 
   void SetPrefService(PrefService* pref_service);
 
+  // PrefNotifier overrides.

[engedy, 2014/05/16 15:19:58]

I might be missing something, but could we not just move this a further down and
group it with the other overrides?

[battre, 2014/05/16 15:58:37]

Done. I need to cast at the caller site now, but that's fine by me.

+  // TODO(battre): Delete this. See crbug.com/373435.
+  virtual void SetPrefServiceDestructionTrace(
+      const std::string& stacktrace) OVERRIDE;
+
  protected:
   // PrefNotifier overrides.
   virtual void OnPreferenceChanged(const std::string& pref_name) OVERRIDE;
   virtual void OnInitializationCompleted(bool succeeded) OVERRIDE;
 
   // A map from pref names to a list of observers. Observers get fired in the
   // order they are added. These should only be accessed externally for unit
   // testing.
   typedef ObserverList<PrefObserver> PrefObserverList;
   typedef base::hash_map<std::string, PrefObserverList*> PrefObserverMap;
@@ skipping 12 matching lines @@
 
   PrefObserverMap pref_observers_;
   PrefInitObserverList init_observers_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(PrefNotifierImpl);
 };
 
 #endif  // BASE_PREFS_PREF_NOTIFIER_IMPL_H_