Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: base/prefs/pref_notifier_impl.cc

Issue 290083006: Store a stacktrace of PrefService destruction in PrefChangeRegistrar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor improvements Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/prefs/pref_notifier_impl.cc
diff --git a/base/prefs/pref_notifier_impl.cc b/base/prefs/pref_notifier_impl.cc
index c02a7b3f5a5bfd8d4bd5c56ce20ca699e6d10346..e2f609e14fe90316946cbe8ba759afc2cbb6dbf3 100644
--- a/base/prefs/pref_notifier_impl.cc
+++ b/base/prefs/pref_notifier_impl.cc
@@ -74,6 +74,19 @@ void PrefNotifierImpl::AddInitObserver(base::Callback<void(bool)> obs) {
init_observers_.push_back(obs);
}
+// TODO(battre): Delete this. See crbug.com/373435.
+void PrefNotifierImpl::SetPrefServiceDestructionTrace(
+ const std::string& stacktrace) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ for (PrefObserverMap::iterator observer_iterator = pref_observers_.begin();
+ observer_iterator != pref_observers_.end();
+ ++observer_iterator) {
+ FOR_EACH_OBSERVER(PrefObserver,
+ *(observer_iterator->second),
+ SetPrefServiceDestructionTrace(stacktrace));
+ }
+}
+
void PrefNotifierImpl::OnPreferenceChanged(const std::string& path) {
FireObservers(path);
}

Powered by Google App Engine
This is Rietveld 408576698