Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/prefs/pref_notifier.h

Issue 290083006: Store a stacktrace of PrefService destruction in PrefChangeRegistrar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor improvements Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/prefs/pref_change_registrar.cc ('K') | « base/prefs/pref_member.cc ('k') | base/prefs/pref_notifier_impl.h » ('j') | base/prefs/pref_notifier_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/pref_notifier.h
diff --git a/base/prefs/pref_notifier.h b/base/prefs/pref_notifier.h
index e0df260c514821fe882111c8813da32faea51ce8..da8b1530a101f909d86dbca7772d8dfb7ec3cce4 100644
--- a/base/prefs/pref_notifier.h
+++ b/base/prefs/pref_notifier.h
@@ -21,6 +21,12 @@ class PrefNotifier {
// Broadcasts the intialization completed notification.
virtual void OnInitializationCompleted(bool succeeded) = 0;
+
+ // TODO(battre): Remove this function, the purpose is to understand whether a
+ // crash in PrefChangeRegistrar::~PrefChangeRegistrar() is caused by a
+ // PrefService already being dead. See crbug.com/373435.
+ virtual void SetPrefServiceDestructionTrace(
engedy 2014/05/16 15:19:58 nit: I would call this BroadcastPrefServiceDestruc
battre 2014/05/16 15:58:37 Done.
+ const std::string& stacktrace) = 0;
engedy 2014/05/16 15:19:58 nit: stack_trace.
battre 2014/05/16 15:58:37 Done.
};
#endif // BASE_PREFS_PREF_NOTIFIER_H_
« base/prefs/pref_change_registrar.cc ('K') | « base/prefs/pref_member.cc ('k') | base/prefs/pref_notifier_impl.h » ('j') | base/prefs/pref_notifier_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698