More descriptive feedback description in feedbacks filed from the SadTab page

More descriptive feedback description in feedbacks filed from the SadTab page

We're working to encourage our users to give us more helpful feedback instructions
as to how to repro any crashes in the renderers.

Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=710221&desc=2#c21

BUG=710221
TEST=Go to chrome://crash and file a feedback from there and make sure to see a
more descriptive title and placeholder text.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2900643004
Cr-Commit-Position: refs/heads/master@{#474533}
Committed: https://chromium.googlesource.com/chromium/src/+/b47d9268ef018f9ed66378c33b317d9a4cb3553e

[afakhry, 2017-05-22 19:20:22]

Description was changed from

==========
More descriptive feedback description in feedbacks filed from the SadTab page

We're working to encourage our users to give us more helpful feedback
instructions
as to how to repro any crashes in the renderers.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/detail?id=710221&desc=2#c21

BUG=710221
TEST=Go to chrome://crash and file a feedback from there and make sure to see a
more descriptive title and placeholder text.
==========

to

==========
More descriptive feedback description in feedbacks filed from the SadTab page

We're working to encourage our users to give us more helpful feedback
instructions
as to how to repro any crashes in the renderers.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/detail?id=710221&desc=2#c21

BUG=710221
TEST=Go to chrome://crash and file a feedback from there and make sure to see a
more descriptive title and placeholder text.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2017-05-22 19:21:36]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2017-05-22 19:21:37]

Xiyuan, another feedback related issue! :)
Please review. Thank you!

[xiyuan, 2017-05-22 19:35:22]

lgtm

[afakhry, 2017-05-22 20:18:52]

afakhry@chromium.org changed reviewers:
+ mkearney@chromium.org

[afakhry, 2017-05-22 20:18:52]

mkearney@chromium.org: Please review changes in 

feedback_private.idl

[afakhry, 2017-05-23 01:52:23]

afakhry@chromium.org changed reviewers:
- mkearney@chromium.org

[afakhry, 2017-05-23 01:52:46]

afakhry@chromium.org changed reviewers:
+ thestig@chromium.org

[afakhry, 2017-05-23 01:52:46]

thestig@chromium.org: Please review changes in 

feedback_private.idl

[Lei Zhang, 2017-05-23 01:54:09]

I defer to chrome/common/extensions/OWNERS, which points to extensions/OWNERS.

[Lei Zhang, 2017-05-23 01:54:58]

On 2017/05/23 01:54:09, Lei Zhang wrote:
> I defer to chrome/common/extensions/OWNERS, which points to extensions/OWNERS.

Though I'd be happy to stamp this as needed.

[afakhry, 2017-05-23 02:17:47]

Description was changed from

==========
More descriptive feedback description in feedbacks filed from the SadTab page

We're working to encourage our users to give us more helpful feedback
instructions
as to how to repro any crashes in the renderers.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/detail?id=710221&desc=2#c21

BUG=710221
TEST=Go to chrome://crash and file a feedback from there and make sure to see a
more descriptive title and placeholder text.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
More descriptive feedback description in feedbacks filed from the SadTab page

We're working to encourage our users to give us more helpful feedback
instructions
as to how to repro any crashes in the renderers.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/detail?id=710221&desc=2#c21

BUG=710221
TEST=Go to chrome://crash and file a feedback from there and make sure to see a
more descriptive title and placeholder text.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2017-05-23 02:17:47]

afakhry@chromium.org changed reviewers:
+ lazyboy@chromium.org

[afakhry, 2017-05-23 02:18:32]

On 2017/05/23 01:54:58, Lei Zhang wrote:
> On 2017/05/23 01:54:09, Lei Zhang wrote:
> > I defer to chrome/common/extensions/OWNERS, which points to
extensions/OWNERS.
> 
> Though I'd be happy to stamp this as needed.

Fair enough. +lazyboy@ Please take a look at feedback_private.idl. Thanks!

[lazyboy, 2017-05-23 18:24:10]

lgtm

https://codereview.chromium.org/2900643004/diff/1/chrome/browser/resources/fe...
File chrome/browser/resources/feedback/js/data.js (right):

https://codereview.chromium.org/2900643004/diff/1/chrome/browser/resources/fe...
chrome/browser/resources/feedback/js/data.js:19: SAD_TAB_CRASH: 'sadTabCrash' 
// Flow of feedback requested from SadTab pages.
Not directly your change, but these should already be available as
chrome.feedbackPrivate.FeedbackFlow because of the enum definition in the idl.

https://codereview.chromium.org/2900643004/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/feedback_private.idl (right):

https://codereview.chromium.org/2900643004/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/feedback_private.idl:32: // Flow when the feedback
is requested from the sad tab ("Aw, Sanp!") page
s/Sanp/Snap

[afakhry, 2017-05-24 17:40:20]

https://codereview.chromium.org/2900643004/diff/1/chrome/browser/resources/fe...
File chrome/browser/resources/feedback/js/data.js (right):

https://codereview.chromium.org/2900643004/diff/1/chrome/browser/resources/fe...
chrome/browser/resources/feedback/js/data.js:19: SAD_TAB_CRASH: 'sadTabCrash' 
// Flow of feedback requested from SadTab pages.
On 2017/05/23 18:24:09, lazyboy wrote:
> Not directly your change, but these should already be available as
> chrome.feedbackPrivate.FeedbackFlow because of the enum definition in the idl.

I see. Thanks for spotting that. I removed it.

https://codereview.chromium.org/2900643004/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/feedback_private.idl (right):

https://codereview.chromium.org/2900643004/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/feedback_private.idl:32: // Flow when the feedback
is requested from the sad tab ("Aw, Sanp!") page
On 2017/05/23 18:24:09, lazyboy wrote:
> s/Sanp/Snap

Done.

[afakhry, 2017-05-24 17:40:42]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-05-24 17:40:42]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2900643004/#ps20001
(title: "lazyboy's comments")

[commit-bot: I haz the power, 2017-05-24 17:41:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:49:19]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[afakhry, 2017-05-24 19:27:44]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 19:28:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2017-05-24 20:31:12]

The CQ bit was unchecked by afakhry@chromium.org

[afakhry, 2017-05-24 20:31:14]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-05-24 20:31:15]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2900643004/#ps40001
(title: "Fix test")

[afakhry, 2017-05-24 20:31:20]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2017-05-24 20:31:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 00:49:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 00:49:30]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[afakhry, 2017-05-25 00:50:29]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2017-05-25 00:51:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 02:42:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495673429329130,
"parent_rev": "43ffa71e810074eb21a15188cc408ab67039b0a8", "commit_rev":
"b47d9268ef018f9ed66378c33b317d9a4cb3553e"}

[commit-bot: I haz the power, 2017-05-25 02:43:06]

Description was changed from

==========
More descriptive feedback description in feedbacks filed from the SadTab page

We're working to encourage our users to give us more helpful feedback
instructions
as to how to repro any crashes in the renderers.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/detail?id=710221&desc=2#c21

BUG=710221
TEST=Go to chrome://crash and file a feedback from there and make sure to see a
more descriptive title and placeholder text.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
More descriptive feedback description in feedbacks filed from the SadTab page

We're working to encourage our users to give us more helpful feedback
instructions
as to how to repro any crashes in the renderers.

Screenshot:
https://bugs.chromium.org/p/chromium/issues/detail?id=710221&desc=2#c21

BUG=710221
TEST=Go to chrome://crash and file a feedback from there and make sure to see a
more descriptive title and placeholder text.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2900643004
Cr-Commit-Position: refs/heads/master@{#474533}
Committed:
https://chromium.googlesource.com/chromium/src/+/b47d9268ef018f9ed66378c33b31...
==========

[commit-bot: I haz the power, 2017-05-25 02:43:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b47d9268ef018f9ed66378c33b31...