Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2991)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2900643004: More descriptive feedback description in feedbacks filed from the SadTab page (Closed)
Patch Set: Fix test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/feedback/show_feedback_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
index b13cf765fee1e86d05d99ee2bb3f87d5ef7e24a0..4b84117e26abcfb6c8d8817b2672edea1b848f23 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
@@ -162,11 +162,17 @@ void FeedbackPrivateAPI::RequestFeedbackForFlow(
base::Closure* FeedbackPrivateGetStringsFunction::test_callback_ = NULL;
ExtensionFunction::ResponseAction FeedbackPrivateGetStringsFunction::Run() {
+ auto params = feedback_private::GetStrings::Params::Create(*args_);
+ EXTENSION_FUNCTION_VALIDATE(params.get());
+
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
#define SET_STRING(id, idr) \
dict->SetString(id, l10n_util::GetStringUTF16(idr))
- SET_STRING("page-title", IDS_FEEDBACK_REPORT_PAGE_TITLE);
+ SET_STRING("page-title",
+ params->flow == FeedbackFlow::FEEDBACK_FLOW_SADTABCRASH
+ ? IDS_FEEDBACK_REPORT_PAGE_TITLE_SAD_TAB_FLOW
+ : IDS_FEEDBACK_REPORT_PAGE_TITLE);
SET_STRING("additionalInfo", IDS_FEEDBACK_ADDITIONAL_INFO_LABEL);
SET_STRING("minimize-btn-label", IDS_FEEDBACK_MINIMIZE_BUTTON_LABEL);
SET_STRING("close-btn-label", IDS_FEEDBACK_CLOSE_BUTTON_LABEL);
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/feedback/show_feedback_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698