Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3520)

Unified Diff: chrome/browser/resources/feedback/js/feedback.js

Issue 2900643004: More descriptive feedback description in feedbacks filed from the SadTab page (Closed)
Patch Set: Fix test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/feedback/js/feedback.js
diff --git a/chrome/browser/resources/feedback/js/feedback.js b/chrome/browser/resources/feedback/js/feedback.js
index ba6e6c14cec89d8c8d02746600935e868595516c..fa861c8462ab25ce90b587dcd7724400102c1eef 100644
--- a/chrome/browser/resources/feedback/js/feedback.js
+++ b/chrome/browser/resources/feedback/js/feedback.js
@@ -260,7 +260,7 @@ function resizeAppWindow() {
$('content-pane').scrollHeight + CONTENT_MARGIN_HEIGHT;
var minHeight = FEEDBACK_MIN_HEIGHT;
- if (feedbackInfo.flow == FeedbackFlow.LOGIN)
+ if (feedbackInfo.flow == chrome.feedbackPrivate.FeedbackFlow.LOGIN)
minHeight = FEEDBACK_MIN_HEIGHT_LOGIN;
height = Math.max(height, minHeight);
@@ -303,9 +303,10 @@ function initialize() {
chrome.runtime.onMessage.addListener(function(request, sender, sendResponse) {
if (request.sentFromEventPage) {
if (!feedbackInfo.flow)
- feedbackInfo.flow = FeedbackFlow.REGULAR;
+ feedbackInfo.flow = chrome.feedbackPrivate.FeedbackFlow.REGULAR;
- if (feedbackInfo.flow == FeedbackFlow.SHOW_SRT_PROMPT) {
+ if (feedbackInfo.flow ==
+ chrome.feedbackPrivate.FeedbackFlow.SHOW_SRT_PROMPT) {
isShowingSrtPrompt = true;
$('content-pane').hidden = true;
@@ -380,7 +381,7 @@ function initialize() {
}
// No URL and file attachment for login screen feedback.
- if (feedbackInfo.flow == FeedbackFlow.LOGIN) {
+ if (feedbackInfo.flow == chrome.feedbackPrivate.FeedbackFlow.LOGIN) {
$('page-url').hidden = true;
$('attach-file-container').hidden = true;
$('attach-file-note').hidden = true;
@@ -394,7 +395,7 @@ function initialize() {
$('performance-info-link').onclick = openSlowTraceWindow;
}
// </if>
- chrome.feedbackPrivate.getStrings(function(strings) {
+ chrome.feedbackPrivate.getStrings(feedbackInfo.flow, function(strings) {
loadTimeData.data = strings;
i18nTemplate.process(document, loadTimeData);
« no previous file with comments | « chrome/browser/resources/feedback/js/event_handler.js ('k') | chrome/common/extensions/api/feedback_private.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698