Properly fall back to manifest short_name when name is empty.

Properly fall back to manifest short_name when name is empty.

If a PWA includes a "name" field in their manifest, but explicitly sets
it to the empty string, it would have an app banner displayed with no
text, as well as no title on its splash screen.

This CL fixes the bug by properly checking if the "name" string is
empty, rather than just null. This check is already performed by the
InstallableManager in the process of determining whether or not a site
is a valid PWA. An additional test is added to ensure the correct
functionality.

BUG=722615
Review-Url: https://codereview.chromium.org/2900623002
Cr-Commit-Position: refs/heads/master@{#473806}
Committed: https://chromium.googlesource.com/chromium/src/+/0b543dd3a72f7d63717ee4c99e74bf01902a1c7c

[dominickn, 2017-05-22 05:08:57]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 05:09:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-05-22 05:09:40]

dominickn@chromium.org changed reviewers:
+ benwells@chromium.org

[dominickn, 2017-05-22 05:09:41]

PTAL, thanks!

[commit-bot: I haz the power, 2017-05-22 06:24:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 06:24:21]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-05-23 04:07:23]

lgtm

[dominickn, 2017-05-23 04:09:31]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-05-23 04:09:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 04:14:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495512571063560, "parent_rev":
"9cc9427a4b67b394747dde2f1b8279a0d3384892", "commit_rev":
"0b543dd3a72f7d63717ee4c99e74bf01902a1c7c"}

[commit-bot: I haz the power, 2017-05-23 04:14:34]

Description was changed from

==========
Properly fall back to manifest short_name when name is empty.

If a PWA includes a "name" field in their manifest, but explicitly sets
it to the empty string, it would have an app banner displayed with no
text, as well as no title on its splash screen.

This CL fixes the bug by properly checking if the "name" string is
empty, rather than just null. This check is already performed by the
InstallableManager in the process of determining whether or not a site
is a valid PWA. An additional test is added to ensure the correct
functionality.

BUG=722615
==========

to

==========
Properly fall back to manifest short_name when name is empty.

If a PWA includes a "name" field in their manifest, but explicitly sets
it to the empty string, it would have an app banner displayed with no
text, as well as no title on its splash screen.

This CL fixes the bug by properly checking if the "name" string is
empty, rather than just null. This check is already performed by the
InstallableManager in the process of determining whether or not a site
is a valid PWA. An additional test is added to ensure the correct
functionality.

BUG=722615

Review-Url: https://codereview.chromium.org/2900623002
Cr-Commit-Position: refs/heads/master@{#473806}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b543dd3a72f7d63717ee4c99e74...
==========

[commit-bot: I haz the power, 2017-05-23 04:14:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b543dd3a72f7d63717ee4c99e74...