Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3477)

Unified Diff: chrome/test/data/banners/manifest_empty_name.json

Issue 2900623002: Properly fall back to manifest short_name when name is empty. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/banners/manifest_empty_name.json
diff --git a/chrome/test/data/banners/manifest_empty_name.json b/chrome/test/data/banners/manifest_empty_name.json
new file mode 100644
index 0000000000000000000000000000000000000000..07b5ae5a8159ca64afbbc4de9a4f5a31f4ea3c0b
--- /dev/null
+++ b/chrome/test/data/banners/manifest_empty_name.json
@@ -0,0 +1,39 @@
+{
+ "short_name": "Manifest",
+ "name": "",
+ "icons": [
+ {
+ "src": "launcher-icon-1x.png",
+ "sizes": "48x48",
+ "type": "image/png"
+ },
+ {
+ "src": "launcher-icon-1-5x.png",
+ "sizes": "72x72",
+ "type": "image/png"
+ },
+ {
+ "src": "launcher-icon-2x.png",
+ "sizes": "96x96",
+ "type": "image/png"
+ },
+ {
+ "src": "launcher-icon-3x.png",
+ "sizes": "144x144",
+ "type": "image/png"
+ },
+ {
+ "src": "launcher-icon-4x.png",
+ "sizes": "192x192",
+ "type": "image/png"
+ },
+ {
+ "src": "image-512px.png",
+ "sizes": "512x512",
+ "type": "image/png"
+ }
+ ],
+ "start_url": "manifest_test_page.html",
+ "display": "standalone",
+ "orientation": "landscape"
+}
« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698