Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2900623002: Properly fall back to manifest short_name when name is empty. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index 5878c7e1ea87420076551aaee5944d5188eae7b8..183bd0ead07195a7f3184d5cbf0ea8e984aed5df 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -97,6 +97,9 @@ public class AppBannerManagerTest {
private static final String WEB_APP_SHORT_TITLE_MANIFEST =
"/chrome/test/data/banners/manifest_short_name_only.json";
+ private static final String WEB_APP_EMPTY_NAME_MANIFEST =
+ "/chrome/test/data/banners/manifest_empty_name.json";
+
private static final String WEB_APP_TITLE = "Manifest test app";
private static final String WEB_APP_SHORT_TITLE = "Manifest";
@@ -611,7 +614,7 @@ public class AppBannerManagerTest {
@Test
@SmallTest
@Feature({"AppBanners"})
- public void testBannerFallsBackToShortName() throws Exception {
+ public void testBannerFallsBackToShortNameWhenNameNotPresent() throws Exception {
triggerWebAppBanner(WebappTestPage.urlOfPageWithServiceWorkerAndManifest(
mTestServer, WEB_APP_SHORT_TITLE_MANIFEST),
WEB_APP_SHORT_TITLE, false);
@@ -620,6 +623,15 @@ public class AppBannerManagerTest {
@Test
@SmallTest
@Feature({"AppBanners"})
+ public void testBannerFallsBackToShortNameWhenNameIsEmpty() throws Exception {
+ triggerWebAppBanner(WebappTestPage.urlOfPageWithServiceWorkerAndManifest(
+ mTestServer, WEB_APP_EMPTY_NAME_MANIFEST),
+ WEB_APP_SHORT_TITLE, false);
+ }
+
+ @Test
+ @SmallTest
+ @Feature({"AppBanners"})
public void testAppInstalledEvent() throws Exception {
triggerWebAppBanner(mWebAppUrl, WEB_APP_TITLE, true);
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698