Closure: remove older, original GYP compilation system

Closure: remove older, original GYP compilation system

R=dpranke@chromium.org,sadrul@chromium.org,fukino@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2887253006
Cr-Commit-Position: refs/heads/master@{#473381}
Committed: https://chromium.googlesource.com/chromium/src/+/68f25648e132ccb799f63e5712a76cc69dc63ed3

[Dan Beam, 2017-05-19 02:15:30]

Description was changed from

==========
Closure: remove older, original GYP compilation system

R=dpranke@chromium.org
BUG=585553
==========

to

==========
Closure: remove older, original GYP compilation system

R=dpranke@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-19 02:19:52]

Description was changed from

==========
Closure: remove older, original GYP compilation system

R=dpranke@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Closure: remove older, original GYP compilation system

R=dpranke@chromium.org,sadrul@chromium.org,fukino@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-05-19 02:19:52]

dbeam@chromium.org changed reviewers:
+ fukino@chromium.org, sadrul@chromium.org

[Dan Beam, 2017-05-19 02:23:00]

+dpranke@ for PRESUBMIT*
+sadrul for ui/keyboard
+fukino@ for everything else

[fukino, 2017-05-19 05:23:04]

Thank you!
lgtm with a nit.

https://codereview.chromium.org/2887253006/diff/1/components/chrome_apps/webs...
File components/chrome_apps/webstore_widget/app/compiled_resources.gyp (left):

https://codereview.chromium.org/2887253006/diff/1/components/chrome_apps/webs...
components/chrome_apps/webstore_widget/app/compiled_resources.gyp:26:
'../cws_widget/compiled_resources.gypi'
Could you remove
components/chrome_apps/webstore_widget/cws_widget/compiled_resources.gypi too?

[sadrul, 2017-05-19 05:54:06]

lgtm

[Dirk Pranke, 2017-05-19 20:26:08]

lgtm

[Dan Beam, 2017-05-19 22:25:45]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 22:26:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-05-19 22:33:23]

https://codereview.chromium.org/2887253006/diff/1/components/chrome_apps/webs...
File components/chrome_apps/webstore_widget/app/compiled_resources.gyp (left):

https://codereview.chromium.org/2887253006/diff/1/components/chrome_apps/webs...
components/chrome_apps/webstore_widget/app/compiled_resources.gyp:26:
'../cws_widget/compiled_resources.gypi'
On 2017/05/19 05:23:03, fukino wrote:
> Could you remove
> components/chrome_apps/webstore_widget/cws_widget/compiled_resources.gypi too?

Done.

[Dan Beam, 2017-05-19 22:33:40]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 22:34:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-05-19 22:48:12]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2017-05-19 22:48:16]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-05-19 22:48:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sadrul@chromium.org, fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2887253006/#ps20001
(title: "compiled_resources.gypi")

[commit-bot: I haz the power, 2017-05-19 22:48:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 23:17:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495234096188570,
"parent_rev": "027183a19bdc7fc48d75dd046e9c8ab8be1700d5", "commit_rev":
"68f25648e132ccb799f63e5712a76cc69dc63ed3"}

[commit-bot: I haz the power, 2017-05-19 23:18:08]

Description was changed from

==========
Closure: remove older, original GYP compilation system

R=dpranke@chromium.org,sadrul@chromium.org,fukino@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Closure: remove older, original GYP compilation system

R=dpranke@chromium.org,sadrul@chromium.org,fukino@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2887253006
Cr-Commit-Position: refs/heads/master@{#473381}
Committed:
https://chromium.googlesource.com/chromium/src/+/68f25648e132ccb799f63e5712a7...
==========

[commit-bot: I haz the power, 2017-05-19 23:18:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/68f25648e132ccb799f63e5712a7...

[findit-for-me, 2017-05-19 23:34:57]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2895773002/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit (https://goo.gl/kROfz5) identified CL at revision 473381 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

[Dan Beam, 2017-05-20 03:09:26]

note to self: beware of stale .pyc files (on bots, locally)

things should now be addressed.