Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2900423002: [mus+ash] Removes WmWindow from ash/wm/root_window_finder.h (Closed)

Created:
3 years, 7 months ago by varkha
Modified:
3 years, 7 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, kalyank, sadrul, dcheng, tfarina, sky
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes WmWindow from ash/wm/root_window_finder.h, ash/wm/workspace/phantom_window_controller.h and connected code. BUG=722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2900423002 Cr-Commit-Position: refs/heads/master@{#474672} Committed: https://chromium.googlesource.com/chromium/src/+/3c60fc576be97e04b4035257194d4e66daac825b

Patch Set 1 #

Patch Set 2 : Remove WmWindow from ash/wm/root_window_finder.h (Chrome compiles) #

Patch Set 3 : Removes WmWindow from ash/wm/root_window_finder.h (removing extra includes) #

Patch Set 4 : Remove WmWindow from ash/wm/root_window_finder.h (tab drag test) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -114 lines) Patch
M ash/autoclick/autoclick_controller.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M ash/display/screen_ash.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 3 chunks +4 lines, -7 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 3 chunks +25 lines, -35 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M ash/mus/screen_mus.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M ash/shelf/shelf_view.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M ash/shell_port.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/test/ui_controls_factory_ash.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M ash/wm/container_finder.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M ash/wm/root_window_finder.h View 1 2 2 chunks +9 lines, -8 lines 0 comments Download
M ash/wm/root_window_finder.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.h View 2 chunks +7 lines, -5 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_ash.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
varkha
WIP, don't review it yet, just for visibility. I am pulling at the ash/wm/root_window_finder.h mentions ...
3 years, 7 months ago (2017-05-24 21:22:51 UTC) #2
varkha
Should be in reasonable shape now. Please take a look.
3 years, 7 months ago (2017-05-25 14:45:59 UTC) #7
sky
LGTM
3 years, 7 months ago (2017-05-25 16:20:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900423002/60001
3 years, 7 months ago (2017-05-25 16:20:47 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 16:25:34 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3c60fc576be97e04b4035257194d...

Powered by Google App Engine
This is Rietveld 408576698