Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: ash/extended_desktop_unittest.cc

Issue 2900423002: [mus+ash] Removes WmWindow from ash/wm/root_window_finder.h (Closed)
Patch Set: Remove WmWindow from ash/wm/root_window_finder.h (tab drag test) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/drag_drop/drag_drop_tracker.cc ('k') | ash/frame/caption_buttons/frame_size_button.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/extended_desktop_unittest.cc
diff --git a/ash/extended_desktop_unittest.cc b/ash/extended_desktop_unittest.cc
index e0e939ece9866b56c17ce48c66f163b92277e2f7..ea9f9e2c4a3ca91993c3b340af6aae0203aac084 100644
--- a/ash/extended_desktop_unittest.cc
+++ b/ash/extended_desktop_unittest.cc
@@ -10,7 +10,6 @@
#include "ash/wm/root_window_finder.h"
#include "ash/wm/window_properties.h"
#include "ash/wm/window_util.h"
-#include "ash/wm_window.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "ui/aura/client/capture_client.h"
@@ -291,24 +290,17 @@ TEST_F(ExtendedDesktopTest, GetRootWindowAt) {
SetSecondaryDisplayLayout(display::DisplayPlacement::LEFT);
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
- EXPECT_EQ(root_windows[1], WmWindow::GetAuraWindow(
- wm::GetRootWindowAt(gfx::Point(-400, 100))));
- EXPECT_EQ(root_windows[1],
- WmWindow::GetAuraWindow(wm::GetRootWindowAt(gfx::Point(-1, 100))));
- EXPECT_EQ(root_windows[0],
- WmWindow::GetAuraWindow(wm::GetRootWindowAt(gfx::Point(0, 300))));
- EXPECT_EQ(root_windows[0],
- WmWindow::GetAuraWindow(wm::GetRootWindowAt(gfx::Point(700, 300))));
+ EXPECT_EQ(root_windows[1], wm::GetRootWindowAt(gfx::Point(-400, 100)));
+ EXPECT_EQ(root_windows[1], wm::GetRootWindowAt(gfx::Point(-1, 100)));
+ EXPECT_EQ(root_windows[0], wm::GetRootWindowAt(gfx::Point(0, 300)));
+ EXPECT_EQ(root_windows[0], wm::GetRootWindowAt(gfx::Point(700, 300)));
// Zero origin.
- EXPECT_EQ(root_windows[0],
- WmWindow::GetAuraWindow(wm::GetRootWindowAt(gfx::Point(0, 0))));
+ EXPECT_EQ(root_windows[0], wm::GetRootWindowAt(gfx::Point(0, 0)));
// Out of range point should return the nearest root window
- EXPECT_EQ(root_windows[1],
- WmWindow::GetAuraWindow(wm::GetRootWindowAt(gfx::Point(-600, 0))));
- EXPECT_EQ(root_windows[0],
- WmWindow::GetAuraWindow(wm::GetRootWindowAt(gfx::Point(701, 100))));
+ EXPECT_EQ(root_windows[1], wm::GetRootWindowAt(gfx::Point(-600, 0)));
+ EXPECT_EQ(root_windows[0], wm::GetRootWindowAt(gfx::Point(701, 100)));
}
TEST_F(ExtendedDesktopTest, GetRootWindowMatching) {
@@ -318,34 +310,32 @@ TEST_F(ExtendedDesktopTest, GetRootWindowMatching) {
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
// Containing rect.
- EXPECT_EQ(root_windows[1], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(-300, 10, 50, 50))));
- EXPECT_EQ(root_windows[0], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(100, 10, 50, 50))));
+ EXPECT_EQ(root_windows[1],
+ wm::GetRootWindowMatching(gfx::Rect(-300, 10, 50, 50)));
+ EXPECT_EQ(root_windows[0],
+ wm::GetRootWindowMatching(gfx::Rect(100, 10, 50, 50)));
// Intersecting rect.
- EXPECT_EQ(root_windows[1], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(-200, 0, 300, 300))));
- EXPECT_EQ(root_windows[0], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(-100, 0, 300, 300))));
+ EXPECT_EQ(root_windows[1],
+ wm::GetRootWindowMatching(gfx::Rect(-200, 0, 300, 300)));
+ EXPECT_EQ(root_windows[0],
+ wm::GetRootWindowMatching(gfx::Rect(-100, 0, 300, 300)));
// Zero origin.
- EXPECT_EQ(root_windows[0], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(0, 0, 0, 0))));
- EXPECT_EQ(root_windows[0], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(0, 0, 1, 1))));
+ EXPECT_EQ(root_windows[0], wm::GetRootWindowMatching(gfx::Rect(0, 0, 0, 0)));
+ EXPECT_EQ(root_windows[0], wm::GetRootWindowMatching(gfx::Rect(0, 0, 1, 1)));
// Empty rect.
- EXPECT_EQ(root_windows[1], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(-400, 100, 0, 0))));
- EXPECT_EQ(root_windows[0], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(100, 100, 0, 0))));
+ EXPECT_EQ(root_windows[1],
+ wm::GetRootWindowMatching(gfx::Rect(-400, 100, 0, 0)));
+ EXPECT_EQ(root_windows[0],
+ wm::GetRootWindowMatching(gfx::Rect(100, 100, 0, 0)));
// Out of range rect should return the primary root window.
- EXPECT_EQ(root_windows[0], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(-600, -300, 50, 50))));
- EXPECT_EQ(root_windows[0], WmWindow::GetAuraWindow(wm::GetRootWindowMatching(
- gfx::Rect(0, 1000, 50, 50))));
+ EXPECT_EQ(root_windows[0],
+ wm::GetRootWindowMatching(gfx::Rect(-600, -300, 50, 50)));
+ EXPECT_EQ(root_windows[0],
+ wm::GetRootWindowMatching(gfx::Rect(0, 1000, 50, 50)));
}
TEST_F(ExtendedDesktopTest, Capture) {
« no previous file with comments | « ash/drag_drop/drag_drop_tracker.cc ('k') | ash/frame/caption_buttons/frame_size_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698