[Reland] Add presubmit rule banning relative header includes

[Reland] Add presubmit rule banning relative header includes

This CL was reverted because it had a bug making it catch all changes to C++
files in the directories it applied to (I thought the fact that I had
successfully uploaded the CL itself verified the rule wouldn't trigger on
unrelated changes...but PRESUBMIT.py is not a C++ file). I have fixed the bug in
this version.

Original CL:
https://codereview.chromium.org/2900173003

Revert:
https://codereview.chromium.org/2897383002

Original description:

Relative header includes (#include path containing "../") can be used to cheat
the dependency system because they're not checked properly. This CL adds a
presubmit rule to catch these.

This rules applies to third_party/WebKit, but not anywhere else in third_party/.
There's one currently existing file I know of that would fail this rule:
ppapi/lib/gl/include/GLES2/gl2.h

I did not change this file when cleaning up the other headers since it appears
to be code imported from a third-party repo. I guess whoever updates this file
will have to bypass the rule.

BUG=724264
Review-Url: https://codereview.chromium.org/2900253003
Cr-Commit-Position: refs/heads/master@{#475587}
Committed: https://chromium.googlesource.com/chromium/src/+/6802cf635c938aabaf9d06ab7394009feb0887fd

[rlanday, 2017-05-24 21:08:50]

rlanday@chromium.org changed reviewers:
+ danakj@chromium.org, jochen@chromium.org

[rlanday, 2017-05-24 21:10:37]

I apologize for the previous version of my presubmit rule accidentally flagging
every C++ file in the directories it applies to...the bug should be fixed in
this version.

https://codereview.chromium.org/2900253003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2900253003/diff/1/PRESUBMIT.py#newcode2176
PRESUBMIT.py:2176: if not relative_includes:
This is the fix here: skip files without relative_includes

[jochen (gone - plz use gerrit), 2017-05-26 11:43:43]

can you please add a test for this?

[rlanday, 2017-05-26 23:55:15]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 23:55:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-26 23:58:42]

On 2017/05/26 at 11:43:43, jochen wrote:
> can you please add a test for this?

Ok, I've added a test

[jochen (gone - plz use gerrit), 2017-05-29 14:12:32]

lgtm

[rlanday, 2017-05-30 17:36:13]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-05-30 17:36:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 17:48:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496165773982390,
"parent_rev": "c3eb6c571952013b977aeeab568163c321617a7b", "commit_rev":
"6802cf635c938aabaf9d06ab7394009feb0887fd"}

[commit-bot: I haz the power, 2017-05-30 17:48:47]

Description was changed from

==========
[Reland] Add presubmit rule banning relative header includes

This CL was reverted because it had a bug making it catch all changes to C++
files in the directories it applied to (I thought the fact that I had
successfully uploaded the CL itself verified the rule wouldn't trigger on
unrelated changes...but PRESUBMIT.py is not a C++ file). I have fixed the bug in
this version.

Original CL:
https://codereview.chromium.org/2900173003

Revert:
https://codereview.chromium.org/2897383002

Original description:

Relative header includes (#include path containing "../") can be used to cheat
the dependency system because they're not checked properly. This CL adds a
presubmit rule to catch these.

This rules applies to third_party/WebKit, but not anywhere else in third_party/.
There's one currently existing file I know of that would fail this rule:
ppapi/lib/gl/include/GLES2/gl2.h

I did not change this file when cleaning up the other headers since it appears
to be code imported from a third-party repo. I guess whoever updates this file
will have to bypass the rule.

BUG=724264
==========

to

==========
[Reland] Add presubmit rule banning relative header includes

This CL was reverted because it had a bug making it catch all changes to C++
files in the directories it applied to (I thought the fact that I had
successfully uploaded the CL itself verified the rule wouldn't trigger on
unrelated changes...but PRESUBMIT.py is not a C++ file). I have fixed the bug in
this version.

Original CL:
https://codereview.chromium.org/2900173003

Revert:
https://codereview.chromium.org/2897383002

Original description:

Relative header includes (#include path containing "../") can be used to cheat
the dependency system because they're not checked properly. This CL adds a
presubmit rule to catch these.

This rules applies to third_party/WebKit, but not anywhere else in third_party/.
There's one currently existing file I know of that would fail this rule:
ppapi/lib/gl/include/GLES2/gl2.h

I did not change this file when cleaning up the other headers since it appears
to be code imported from a third-party repo. I guess whoever updates this file
will have to bypass the rule.

BUG=724264

Review-Url: https://codereview.chromium.org/2900253003
Cr-Commit-Position: refs/heads/master@{#475587}
Committed:
https://chromium.googlesource.com/chromium/src/+/6802cf635c938aabaf9d06ab7394...
==========

[commit-bot: I haz the power, 2017-05-30 17:48:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6802cf635c938aabaf9d06ab7394...