Add presubmit rule banning relative header includes

Add presubmit rule banning relative header includes

Relative header includes (#include path containing "../") can be used to cheat
the dependency system because they're not checked properly. This CL adds a
presubmit rule to catch these.

This rules applies to third_party/WebKit, but not anywhere else in third_party/.
There's one currently existing file I know of that would fail this rule:
ppapi/lib/gl/include/GLES2/gl2.h

I did not change this file when cleaning up the other headers since it appears
to be code imported from a third-party repo. I guess whoever updates this file
will have to bypass the rule.

BUG=724264
Review-Url: https://codereview.chromium.org/2900173003
Cr-Commit-Position: refs/heads/master@{#474396}
Committed: https://chromium.googlesource.com/chromium/src/+/90089e1929d8ec7bda755456e7a54808a2c843ea

[rlanday, 2017-05-23 22:34:14]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 22:35:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-23 22:35:28]

rlanday@chromium.org changed reviewers:
+ jochen@chromium.org

[rlanday, 2017-05-23 22:35:29]

Example of what the error looks like:

You added one or more relative #include paths (including "../").
These shouldn't be used because they can be used to include headers
from code that's not correctly specified as a dependency in the
relevant BUILD.gn file(s).
  third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
    #include "../VisibleUnits.h"
    #include "test/../VisibleUnits.h" \
  third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.cpp
    #include "../markers/DocumentMarkerList.h"

[commit-bot: I haz the power, 2017-05-23 22:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 22:48:25]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-05-24 19:38:58]

lgtm

[rlanday, 2017-05-24 19:46:24]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:46:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:52:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495655184763170, "parent_rev":
"5d947f5a0c60d33fa16b6609978bd712a497cb00", "commit_rev":
"90089e1929d8ec7bda755456e7a54808a2c843ea"}

[commit-bot: I haz the power, 2017-05-24 19:52:39]

Description was changed from

==========
Add presubmit rule banning relative header includes

Relative header includes (#include path containing "../") can be used to cheat
the dependency system because they're not checked properly. This CL adds a
presubmit rule to catch these.

This rules applies to third_party/WebKit, but not anywhere else in third_party/.
There's one currently existing file I know of that would fail this rule:
ppapi/lib/gl/include/GLES2/gl2.h

I did not change this file when cleaning up the other headers since it appears
to be code imported from a third-party repo. I guess whoever updates this file
will have to bypass the rule.

BUG=724264
==========

to

==========
Add presubmit rule banning relative header includes

Relative header includes (#include path containing "../") can be used to cheat
the dependency system because they're not checked properly. This CL adds a
presubmit rule to catch these.

This rules applies to third_party/WebKit, but not anywhere else in third_party/.
There's one currently existing file I know of that would fail this rule:
ppapi/lib/gl/include/GLES2/gl2.h

I did not change this file when cleaning up the other headers since it appears
to be code imported from a third-party repo. I guess whoever updates this file
will have to bypass the rule.

BUG=724264

Review-Url: https://codereview.chromium.org/2900173003
Cr-Commit-Position: refs/heads/master@{#474396}
Committed:
https://chromium.googlesource.com/chromium/src/+/90089e1929d8ec7bda755456e7a5...
==========

[commit-bot: I haz the power, 2017-05-24 19:52:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90089e1929d8ec7bda755456e7a5...

[danakj, 2017-05-24 20:12:51]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2017-05-24 20:12:52]

This is failing on a CL that does not add such includes.
https://chromium-review.googlesource.com/c/513043

[danakj, 2017-05-24 20:13:11]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2897383002/ by danakj@chromium.org.

The reason for reverting is: Fails when it should not..

[danakj, 2017-05-24 20:13:56]

On 2017/05/24 20:12:52, danakj wrote:
> This is failing on a CL that does not add such includes.
> https://chromium-review.googlesource.com/c/513043

Notably:

% git show|grep "\.\./"|wc -l
0