DescriptionRevert of Add presubmit rule banning relative header includes (patchset #1 id:1 of https://codereview.chromium.org/2900173003/ )
Reason for revert:
Fails when it should not.
Original issue's description:
> Add presubmit rule banning relative header includes
>
> Relative header includes (#include path containing "../") can be used to cheat
> the dependency system because they're not checked properly. This CL adds a
> presubmit rule to catch these.
>
> This rules applies to third_party/WebKit, but not anywhere else in third_party/.
> There's one currently existing file I know of that would fail this rule:
> ppapi/lib/gl/include/GLES2/gl2.h
>
> I did not change this file when cleaning up the other headers since it appears
> to be code imported from a third-party repo. I guess whoever updates this file
> will have to bypass the rule.
>
> BUG=724264
>
> Review-Url: https://codereview.chromium.org/2900173003
> Cr-Commit-Position: refs/heads/master@{#474396}
> Committed: https://chromium.googlesource.com/chromium/src/+/90089e1929d8ec7bda755456e7a54808a2c843ea
TBR=jochen@chromium.org,rlanday@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=724264
Review-Url: https://codereview.chromium.org/2897383002
Cr-Commit-Position: refs/heads/master@{#474400}
Committed: https://chromium.googlesource.com/chromium/src/+/c5cf3f2778b406509d532111bb7005f25d3dfcee
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|