Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2900223002:
Turn on heap profiling for memory.desktop benchmark (Closed)
DescriptionTurn on heap profiling for memory.desktop benchmark
The memory metric related to malloc used by telemetry is noisy
because it is based on the HeapWalk implementation and affected
by the tracing infra-structure.
A shim_allocated_size / shim_allocated_objects metric is added
to provide a more precise metric based on objects allocated
through the shim. This metric is much more precise but require
heap-profiling to be turn on.
Related to:
https://codereview.chromium.org/2865333002
https://codereview.chromium.org/2801153004
Note to Perf sheriffs, this CL may:
* affect memory consumption for the 'memory.desktop' benchmarks
* slowdown 'memory.desktop'benchmarks by adding an extra cost for tracking allocations.
R=erikchen
BUG=713191
Review-Url: https://codereview.chromium.org/2900223002
Cr-Commit-Position: refs/heads/master@{#474423}
Committed: https://chromium.googlesource.com/chromium/src/+/9af9d8069f1a0e3862c5c8526e20ef529f402134
Patch Set 1 #
Messages
Total messages: 23 (15 generated)
Description was changed from ========== Turn on heap profiling for memory.desktop benchmark CC=erikchen R= BUG= ========== to ========== Turn on heap profiling for memory.desktop benchmark CC=erikchen R= BUG= ==========
etienneb@chromium.org changed reviewers: + dpranke@chromium.org
Description was changed from ========== Turn on heap profiling for memory.desktop benchmark CC=erikchen R= BUG= ========== to ========== Turn on heap profiling for memory.desktop benchmark CC=erikchen R= BUG=713191 ==========
erikchen@chromium.org changed reviewers: + erikchen@chromium.org
Can we also turn this on for system_health.memory_desktop? Also please add a crbug and a more detailed description for why we're doing this. Otherwise lgtm.
Description was changed from ========== Turn on heap profiling for memory.desktop benchmark CC=erikchen R= BUG=713191 ========== to ========== Turn on heap profiling for memory.desktop benchmark The memory metric related to malloc used by telemetry is noisy because it is based on the HeapWalk implementation and affected by the tracing infra-structure. A shim_allocated_size / shim_allocated_objects metric is added to provide a more precise metric based on objects allocated through the shim. This metric is much more precise but require heap-profiling to be turn on. Related to: https://codereview.chromium.org/2865333002 https://codereview.chromium.org/2801153004/ R=erikchen BUG=713191 ==========
On 2017/05/23 23:27:47, erikchen wrote: > Can we also turn this on for system_health.memory_desktop? Also please add a > crbug and a more detailed description for why we're doing this. > > Otherwise lgtm. still lgtm. will you have a separate CL to turn it on for system_health.memory_desktop
PTAnL and CQ I need an owner (Dirk!?)
etienneb@chromium.org changed reviewers: + nednguyen@google.com - dpranke@chromium.org
PTAnL and CQ I need an owner lgtm (nednguyen)
On 2017/05/23 23:36:24, etienneb wrote: > PTAnL and CQ > I need an owner lgtm (nednguyen) lgtm but can you add a note in the description to let Perf sheriffs note that this can move the current memory metrics?
Description was changed from ========== Turn on heap profiling for memory.desktop benchmark The memory metric related to malloc used by telemetry is noisy because it is based on the HeapWalk implementation and affected by the tracing infra-structure. A shim_allocated_size / shim_allocated_objects metric is added to provide a more precise metric based on objects allocated through the shim. This metric is much more precise but require heap-profiling to be turn on. Related to: https://codereview.chromium.org/2865333002 https://codereview.chromium.org/2801153004/ R=erikchen BUG=713191 ========== to ========== Turn on heap profiling for memory.desktop benchmark The memory metric related to malloc used by telemetry is noisy because it is based on the HeapWalk implementation and affected by the tracing infra-structure. A shim_allocated_size / shim_allocated_objects metric is added to provide a more precise metric based on objects allocated through the shim. This metric is much more precise but require heap-profiling to be turn on. Related to: https://codereview.chromium.org/2865333002 https://codereview.chromium.org/2801153004/ Note to Perf sheriffs, this CL may: * affect memory consumption for the 'memory.desktop' benchmarks * slowdown 'memory.desktop'benchmarks by adding an extra cost for tracking allocations. R=erikchen BUG=713191 ==========
A comment is added to the description for the sheriff. erikchen@, I prefer to turn on heap profiling for 'system_health.memory_desktop' in a separate CL after observing side-effects of landing this CL.
Description was changed from ========== Turn on heap profiling for memory.desktop benchmark The memory metric related to malloc used by telemetry is noisy because it is based on the HeapWalk implementation and affected by the tracing infra-structure. A shim_allocated_size / shim_allocated_objects metric is added to provide a more precise metric based on objects allocated through the shim. This metric is much more precise but require heap-profiling to be turn on. Related to: https://codereview.chromium.org/2865333002 https://codereview.chromium.org/2801153004/ Note to Perf sheriffs, this CL may: * affect memory consumption for the 'memory.desktop' benchmarks * slowdown 'memory.desktop'benchmarks by adding an extra cost for tracking allocations. R=erikchen BUG=713191 ========== to ========== Turn on heap profiling for memory.desktop benchmark The memory metric related to malloc used by telemetry is noisy because it is based on the HeapWalk implementation and affected by the tracing infra-structure. A shim_allocated_size / shim_allocated_objects metric is added to provide a more precise metric based on objects allocated through the shim. This metric is much more precise but require heap-profiling to be turn on. Related to: https://codereview.chromium.org/2865333002 https://codereview.chromium.org/2801153004 Note to Perf sheriffs, this CL may: * affect memory consumption for the 'memory.desktop' benchmarks * slowdown 'memory.desktop'benchmarks by adding an extra cost for tracking allocations. R=erikchen BUG=713191 ==========
The CQ bit was checked by etienneb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495659665238310, "parent_rev":
"a20ad1f387a72fbc852399346ed55b3bea19a23f", "commit_rev":
"9af9d8069f1a0e3862c5c8526e20ef529f402134"}
Message was sent while issue was closed.
Description was changed from ========== Turn on heap profiling for memory.desktop benchmark The memory metric related to malloc used by telemetry is noisy because it is based on the HeapWalk implementation and affected by the tracing infra-structure. A shim_allocated_size / shim_allocated_objects metric is added to provide a more precise metric based on objects allocated through the shim. This metric is much more precise but require heap-profiling to be turn on. Related to: https://codereview.chromium.org/2865333002 https://codereview.chromium.org/2801153004 Note to Perf sheriffs, this CL may: * affect memory consumption for the 'memory.desktop' benchmarks * slowdown 'memory.desktop'benchmarks by adding an extra cost for tracking allocations. R=erikchen BUG=713191 ========== to ========== Turn on heap profiling for memory.desktop benchmark The memory metric related to malloc used by telemetry is noisy because it is based on the HeapWalk implementation and affected by the tracing infra-structure. A shim_allocated_size / shim_allocated_objects metric is added to provide a more precise metric based on objects allocated through the shim. This metric is much more precise but require heap-profiling to be turn on. Related to: https://codereview.chromium.org/2865333002 https://codereview.chromium.org/2801153004 Note to Perf sheriffs, this CL may: * affect memory consumption for the 'memory.desktop' benchmarks * slowdown 'memory.desktop'benchmarks by adding an extra cost for tracking allocations. R=erikchen BUG=713191 Review-Url: https://codereview.chromium.org/2900223002 Cr-Commit-Position: refs/heads/master@{#474423} Committed: https://chromium.googlesource.com/chromium/src/+/9af9d8069f1a0e3862c5c8526e20... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9af9d8069f1a0e3862c5c8526e20... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
